-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins #25714
Conversation
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the obvious question is... can this script be a jenkins job?
Or GitHub Action |
Codecov Report
@@ Coverage Diff @@
## master #25714 +/- ##
==========================================
- Coverage 72.82% 72.82% -0.01%
==========================================
Files 775 775
Lines 102928 102928
==========================================
- Hits 74957 74953 -4
- Misses 26517 26521 +4
Partials 1454 1454
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It actually is part of
This is a good reminder that I forgot to update that job too, just did |
Unfortunately, our half done GH release automation is probably slowly drifting away from our actual release scripts |
Also, arguably we should be solving this problem by hitting Jenkins directly and gathering results at the end instead of using more expensive/indirect GH PR comments. All of that is more work than bumping the timeout though, thus the current fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It would greatly reduce the need of babysitting jenkins
apache#25714) * Add a 30 second sleep in mass_comment.py to avoid overwhelming Jenkins * Update comment_pr_trigger_phrases.sh
I found that running everything at once led to dropped jobs and conflicts between jobs (e.g. Gradle issues, Jenkins worker failures). This helped dramatically (I only had one or two jobs with Jenkins issues when I did this, as opposed to 20+). It also avoids harming the Jenkins experience for others who are planning on doing normal CI.
I also removed
Java Portability examples on Dataflow with Java 11
since it doesn't seem to be a real postcommit (see #25600 (comment))This will cause the script to run for around 1.25 hours, but shouldn't make a huge difference in the time to completion of the jobs themselves since a full Jenkins queue tends to be the blocker here anyways.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.