Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert workers for java tests #25579

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Revert workers for java tests #25579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bbad0f
Revert workers for java tests
johnjcasey Feb 21, 2023
84941d3
revert windows workers
johnjcasey Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/java_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
check_gcp_variables:
timeout-minutes: 5
name: "Check GCP variables set"
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
outputs:
gcp-variables-set: ${{ steps.check_gcp_variables.outputs.gcp-variables-set }}
steps:
Expand All @@ -66,7 +66,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [[self-hosted, ubuntu-20.04], macos-latest, [self-hosted, windows-server-2019]]
os: [ubuntu-latest, macos-latest, [self-hosted, windows-server-2019]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change this to windows-latest too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do

steps:
- name: Check out code
uses: actions/checkout@v3
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [[self-hosted, ubuntu-20.04], macos-latest, [self-hosted, windows-server-2019]]
os: [ubuntu-latest, macos-latest, [self-hosted, windows-server-2019]]
steps:
- name: Check out code
uses: actions/checkout@v3
Expand Down Expand Up @@ -164,7 +164,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [[self-hosted, ubuntu-20.04],[self-hosted, windows-server-2019]]
os: [ubuntu-latest,[self-hosted, windows-server-2019]]
if: |
needs.check_gcp_variables.outputs.gcp-variables-set == 'true' && (
(github.event_name == 'push' || github.event_name == 'schedule') ||
Expand Down