Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Tiny lint fixes #25564

Merged
merged 2 commits into from
Feb 20, 2023
Merged

[prism] Tiny lint fixes #25564

merged 2 commits into from
Feb 20, 2023

Conversation

lostluck
Copy link
Contributor

Fix urns package comment.
Use any instead of interface{} in config_test.go
Fix checkpointing typo.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #25564 (778e087) into master (85ebc2f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25564   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files         771      771           
  Lines      101870   101870           
=======================================
+ Hits        73479    73481    +2     
+ Misses      26966    26964    -2     
  Partials     1425     1425           
Flag Coverage Δ
go 51.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/go/pkg/beam/runners/prism/internal/urns/urns.go 100.00% <ø> (ø)
.../beam/runners/prism/internal/jobservices/server.go 76.00% <0.00%> (+8.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey jrmccluskey merged commit 63e4c37 into master Feb 20, 2023
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
* Doc commment typo.

* [prism] tiny lint fixes
@lostluck lostluck deleted the tinyLintFixes branch April 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants