Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#25541] Stop use of self hosted runners for some workflows. #25542

Merged
merged 1 commit into from
Feb 17, 2023
+12 −12
Merged

[#25541] Stop use of self hosted runners for some workflows. #25542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/git_tag_released_version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:

jobs:
generate_tags:
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not totally clear if these release tasks will work on hosted runners (or if they'll work at all), but its probably fine to include them. I may try these out during my release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was the bot that tagged finished issues/PRs with the release that includes them, and since a release just went out...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that one is different - this is only run manually and can do one of the release steps (tagging a released version in GitHub) -

beam/.github/workflows/git_tag_released_version.yml

Line 24 in fac6792

workflow_dispatch:
(workflow_dispatch means manual trigger only). You're thinking of

beam/.github/workflows/assign_milestone.yml

Line 20 in 20c8d3a

name: Assign Milestone on issue close

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately, that should be functioning fine since its on a hosted runner

env:
VERSION_PATH: ${{ github.event.inputs.VERSION_TAG }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/go_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ concurrency:
cancel-in-progress: true
jobs:
build:
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
name: Go Build
steps:
- name: Check out code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-tagger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:

jobs:
label:
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
permissions:
issues: write
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/label_prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on: [pull_request_target]
permissions: read-all
jobs:
label:
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-bot-new-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
statuses: read
# Don't run on forks
if: github.repository == 'apache/beam'
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup Node
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-bot-prs-needing-attention.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
statuses: read
# Don't run on forks
if: github.repository == 'apache/beam'
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup Node
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_github_release_notes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ permissions: read-all

jobs:
set-properties:
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
outputs:
properties: ${{ steps.test-properties.outputs.properties }}
steps:
Expand All @@ -41,7 +41,7 @@ jobs:
uses: ./.github/actions/setup-default-test-properties

publish_github_release_notes:
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
needs: set-properties
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reportGenerator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
jobs:
assign:
name: Generate issue report
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup Node
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/self-assign.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
issues: write
name: Take or close an issue
if: ${{ !github.event.issue.pull_request }}
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v6
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
permissions: read-all
jobs:
stale:
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/triaged-on-assign.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
permissions:
issues: write
name: Mark issue as triaged when assigned
runs-on: [self-hosted, ubuntu-20.04]
runs-on: ubuntu-latest
steps:
- run: |
ISSUE_NUMBER="$(jq '.issue.number' $GITHUB_EVENT_PATH)"
Expand Down