Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo - metdata -> metadata #25399

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Feb 9, 2023

Noticed a small typo


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

damccorm commented Feb 9, 2023

R: @AnandInguva

Copy link
Contributor

@AnandInguva AnandInguva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I probably didn't notice this because of code auto completion in PyCharm. Thanks for catching it.

@AnandInguva AnandInguva mentioned this pull request Feb 9, 2023
3 tasks
@damccorm
Copy link
Contributor Author

damccorm commented Feb 9, 2023

retest this please

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #25399 (bf709ea) into master (e659c83) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master   #25399   +/-   ##
=======================================
  Coverage   72.91%   72.92%           
=======================================
  Files         746      746           
  Lines       99264    99264           
=======================================
+ Hits        72377    72384    +7     
+ Misses      25521    25515    -6     
+ Partials     1366     1365    -1     
Flag Coverage Δ
python 82.39% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...am/examples/inference/run_inference_side_inputs.py 35.00% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/base.py 96.12% <100.00%> (ø)
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (-1.34%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 93.28% <0.00%> (-0.75%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 81.74% <0.00%> (-0.15%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 93.13% <0.00%> (+0.63%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.77% <0.00%> (+1.26%) ⬆️
sdks/go/pkg/beam/core/metrics/dumper.go 53.96% <0.00%> (+4.76%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm
Copy link
Contributor Author

damccorm commented Feb 9, 2023

Run Python_Runners PreCommit

@damccorm damccorm merged commit 9e067c6 into master Feb 9, 2023
@damccorm damccorm deleted the users/damccorm/metadata-typo branch February 9, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants