-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Added Tensorflow Model Handler #25368
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25368 +/- ##
==========================================
- Coverage 72.90% 72.76% -0.14%
==========================================
Files 746 749 +3
Lines 99270 99439 +169
==========================================
- Hits 72369 72357 -12
- Misses 25538 25719 +181
Partials 1363 1363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did an initial review. Left few comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks pretty good, just had a few questions
sdks/python/apache_beam/ml/inference/tensorflow_inference_test.py
Outdated
Show resolved
Hide resolved
Ready for review, PTAL. Checks passed mod PyLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just left few comments.
sdks/python/apache_beam/examples/inference/tensorflow_imagenet_segmentation.py
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/tensorflow_imagenet_segmentation.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/tensorflow_imagenet_segmentation.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/ml/inference/tensorflow_inference_it_test.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/ml/inference/tensorflow_inference_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a few more comments, otherwise looks good (linting/formatting is also failing)
sdks/python/apache_beam/ml/inference/tensorflow_inference_it_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Native TF Model Handler with support for
numpy
andtensorflow.Tensor
types discussed in the design doc:Sample Job Run on Dataflow produces the following output for integration test: (true_label, predicted_label)
Part of #25366
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.