Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Added Tensorflow Model Handler #25368

Merged
merged 53 commits into from
Feb 15, 2023

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Feb 7, 2023

Native TF Model Handler with support for numpy and tensorflow.Tensor types discussed in the design doc:
Sample Job Run on Dataflow produces the following output for integration test: (true_label, predicted_label)

1,1
4,4
0,0
7,7
3,3
5,5
8,8

Part of #25366


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@riteshghorse riteshghorse marked this pull request as draft February 7, 2023 19:32
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #25368 (627fdd9) into master (1dfd89d) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #25368      +/-   ##
==========================================
- Coverage   72.90%   72.76%   -0.14%     
==========================================
  Files         746      749       +3     
  Lines       99270    99439     +169     
==========================================
- Hits        72369    72357      -12     
- Misses      25538    25719     +181     
  Partials     1363     1363              
Flag Coverage Δ
python 81.96% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ples/inference/tensorflow_imagenet_segmentation.py 0.00% <0.00%> (ø)
...mples/inference/tensorflow_mnist_classification.py 0.00% <0.00%> (ø)
...n/apache_beam/ml/inference/tensorflow_inference.py 0.00% <0.00%> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 74.66% <0.00%> (-2.00%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.08% <0.00%> (-0.17%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.16% <0.00%> (-0.15%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riteshghorse riteshghorse marked this pull request as ready for review February 7, 2023 23:37
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@AnandInguva AnandInguva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an initial review. Left few comments. Thanks!

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks pretty good, just had a few questions

@riteshghorse
Copy link
Contributor Author

Ready for review, PTAL. Checks passed mod PyLint

Copy link
Contributor

@AnandInguva AnandInguva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left few comments.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a few more comments, otherwise looks good (linting/formatting is also failing)

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@damccorm damccorm merged commit 8bf324d into apache:master Feb 15, 2023
@riteshghorse riteshghorse deleted the tf-model-handler branch February 15, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants