-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Two Counter Metric in BigQuery Write Schema Transform #25155
Conversation
merging new changes from beam to local fork
r: @pabloem |
...pache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
Outdated
Show resolved
Hide resolved
…otation to reduce the number of calls to counter.inc() for better performance.
this seems reasonable. We may add more metrics to the elm/err counter, but we're good as-is for now, huh? |
LGTM. LMK if we should merge |
I'll probably change the name of each counter to be more descriptive of the IO type they are instrumented for. But that can wait till I add in Pub/Sub read metrics and I'll make the change. Think this is good for now. Feel free to merge it if you think It's okay! Thanks @pabloem for all the suggestion! |
@pabloem kindly pinging here to see if it's okay to merge this PR |
Run Java_GCP_IO_Direct PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
lgtm thanks @nickuncaged1201 ! |
Adding two metrics, an input PCollection element count and one write failure count in BigQuery write schema transform. The metrics will be used for Syndeo monitoring integration.