Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two Counter Metric in BigQuery Write Schema Transform #25155

Merged
merged 7 commits into from
Feb 9, 2023
Merged

Add Two Counter Metric in BigQuery Write Schema Transform #25155

merged 7 commits into from
Feb 9, 2023

Conversation

nickuncaged1201
Copy link
Contributor

Adding two metrics, an input PCollection element count and one write failure count in BigQuery write schema transform. The metrics will be used for Syndeo monitoring integration.

@nickuncaged1201
Copy link
Contributor Author

nickuncaged1201 commented Jan 25, 2023

r: @pabloem
r: @manavgarg

@pabloem
Copy link
Member

pabloem commented Feb 6, 2023

this seems reasonable. We may add more metrics to the elm/err counter, but we're good as-is for now, huh?

@pabloem
Copy link
Member

pabloem commented Feb 6, 2023

LGTM. LMK if we should merge

@nickuncaged1201
Copy link
Contributor Author

I'll probably change the name of each counter to be more descriptive of the IO type they are instrumented for. But that can wait till I add in Pub/Sub read metrics and I'll make the change. Think this is good for now. Feel free to merge it if you think It's okay!

Thanks @pabloem for all the suggestion!

@nickuncaged1201
Copy link
Contributor Author

@pabloem kindly pinging here to see if it's okay to merge this PR

@pabloem pabloem marked this pull request as ready for review February 9, 2023 18:28
@pabloem
Copy link
Member

pabloem commented Feb 9, 2023

Run Java_GCP_IO_Direct PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@pabloem pabloem merged commit 78c1564 into apache:master Feb 9, 2023
@pabloem
Copy link
Member

pabloem commented Feb 9, 2023

lgtm thanks @nickuncaged1201 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants