Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info in documentation #25099

Merged

Conversation

shub-kris
Copy link
Contributor

This PR aims to add more information on the arguments required to pass for running the large language model runinference pipeline.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@shub-kris
Copy link
Contributor Author

Hi, @damccorm please find the updated documentation.

Comment on lines 31 to 32
1. Locally on your machine: `python main.py --runner DirectRunner --model_state_dict_path path_to_saved_model`. You need to have 45 GB of disk space available to run this example.
2. On Google Cloud using Dataflow: `python main.py --runner DataflowRunner --model_state_dict_path path_to_saved_model --project PROJECT_ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Locally on your machine: `python main.py --runner DirectRunner --model_state_dict_path path_to_saved_model`. You need to have 45 GB of disk space available to run this example.
2. On Google Cloud using Dataflow: `python main.py --runner DataflowRunner --model_state_dict_path path_to_saved_model --project PROJECT_ID
1. Locally on your machine: `python main.py --runner DirectRunner --model_state_dict_path <local or remote path to state_dict> path_to_saved_model <local or remote path to saved model file> `. You need to have 45 GB of disk space available to run this example.
2. On Google Cloud using Dataflow: `python main.py --runner DataflowRunner --model_state_dict_path <local or remote path to state_dict> path_to_saved_model <local or remote path to saved model file> --project PROJECT_ID

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please include instructions on pulling the model to get the state_dict/saved model file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shub-kris shub-kris requested a review from damccorm January 23, 2023 09:55
@damccorm damccorm merged commit 897fffd into apache:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants