Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate google-python-cloud-debugger dependency in base_image_requirements #25088

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 19, 2023

Fixes #23487

Per https://cloud.google.com/debugger/docs/release-notes: "Cloud Debugger is deprecated and will be shutdown May 31, 2023."

This dep is also a blocker of building python container on a mac.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Abacn
Copy link
Contributor Author

Abacn commented Jan 19, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #25088 (9eb725a) into master (b554040) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25088      +/-   ##
==========================================
- Coverage   73.13%   73.12%   -0.01%     
==========================================
  Files         735      735              
  Lines       98151    98153       +2     
==========================================
- Hits        71782    71776       -6     
- Misses      25006    25014       +8     
  Partials     1363     1363              
Flag Coverage Δ
python 82.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (-1.34%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.49% <0.00%> (-0.64%) ⬇️
sdks/python/apache_beam/typehints/typehints.py 92.88% <0.00%> (-0.17%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.13%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 94.00% <0.00%> (+1.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@tvalentyn
Copy link
Contributor

tvalentyn commented Jan 19, 2023

noting that this CL doesn't regenerate the container dependencies, but this happens regularly, and done at least before a release.

@Abacn
Copy link
Contributor Author

Abacn commented Jan 19, 2023

yeah thanks for reminding.

@Abacn Abacn merged commit 1d4345a into apache:master Jan 19, 2023
@Abacn Abacn deleted the removeclouddbgdep branch January 19, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Eliminate google-python-cloud-debugger dependency in base_image_requirements
2 participants