Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task #25064: Data Sampling proto changes #25065

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

rohdesamuel
Copy link
Contributor

@rohdesamuel rohdesamuel commented Jan 18, 2023

This adds:

  • The Sample instruction (SampleRequest and SampleResponse) to query the samples from an SDK
  • The "beam:protocol:data_sampling:v1" capability to track which SDKs can sample

Task #25064


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@rohdesamuel
Copy link
Contributor Author

R: @pabloem
R: @lukecwik

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #25065 (71e58c3) into master (89cd059) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 71e58c3 differs from pull request most recent head cc8918f. Consider uploading reports for the commit cc8918f to get more accurate results

@@           Coverage Diff           @@
##           master   #25065   +/-   ##
=======================================
  Coverage   73.05%   73.06%           
=======================================
  Files         740      740           
  Lines       98734    98762   +28     
=======================================
+ Hits        72132    72160   +28     
  Misses      25238    25238           
  Partials     1364     1364           
Flag Coverage Δ
python 82.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eam/runners/portability/fn_api_runner/execution.py 92.49% <0.00%> (-0.64%) ⬇️
...ache/beam/model/fn_execution/v1/beam_fn_api_pb2.py 100.00% <0.00%> (ø)
...ache/beam/model/pipeline/v1/beam_runner_api_pb2.py 100.00% <0.00%> (ø)
...beam/model/pipeline/v1/beam_runner_api_pb2_urns.py 100.00% <0.00%> (ø)
...on/apache_beam/runners/dataflow/dataflow_runner.py 81.88% <0.00%> (+0.14%) ⬆️
sdks/go/pkg/beam/io/mongodbio/read.go 31.20% <0.00%> (+0.23%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the model label Jan 18, 2023
@rohdesamuel rohdesamuel changed the title #25064: Data Sampling proto changes Task #25064: Data Sampling proto changes Jan 18, 2023
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted some of my earlier comments.

@rohdesamuel rohdesamuel requested a review from lukecwik January 19, 2023 19:17
Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good, just want confirmation that you want AND and not OR

@rohdesamuel rohdesamuel requested a review from lukecwik January 24, 2023 18:05
@lukecwik
Copy link
Member

Run Python_Transforms PreCommit

@rohdesamuel rohdesamuel force-pushed the data-sampling branch 2 times, most recently from fd5e08a to cc8918f Compare January 25, 2023 00:08
This adds the protos for querying any data samples from the SDK.
@lukecwik
Copy link
Member

Run Java PreCommit

1 similar comment
@rohdesamuel
Copy link
Contributor Author

Run Java PreCommit

@lukecwik lukecwik merged commit b497cc4 into apache:master Jan 26, 2023
zechenj18 added a commit to zechenj18/beam that referenced this pull request Aug 3, 2023
BjornPrime pushed a commit to BjornPrime/my-beam that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants