-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Python Container Dependencies #25042
Updated Python Container Dependencies #25042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25042 +/- ##
=======================================
Coverage 73.12% 73.13%
=======================================
Files 735 735
Lines 98147 98149 +2
=======================================
+ Hits 71773 71781 +8
+ Misses 25011 25005 -6
Partials 1363 1363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Run Python_Transforms PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it would be good to have automation around checking these, eh?
Notably these won't have received much testing yet, if you cut release branch right away. |
Are these not tested by the precommits? |
There is some test coverage in https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Commit/14530/ , but not thorough. This may change later this quarter with us using external containers for Python SDK. Also, Dataflow ValidatesContainer suite (not automatically triggered) could provide more coverage. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.