Allow to set timeout for finishing a remote bundle in Samza portable runner #25031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xinyuiscool please help take a look, thanks. |
mynameborat
reviewed
Jan 17, 2023
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaPortablePipelineOptions.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaDoFnRunners.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaDoFnRunners.java
Outdated
Show resolved
Hide resolved
I didn't do that because there is no test cases created for this |
|
@mynameborat Thanks for helping review. I addressed your comments, let me know if you have other questions. |
mynameborat
reviewed
Jan 17, 2023
runners/samza/src/test/java/org/apache/beam/runners/samza/util/RunWithTimeoutTest.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/util/RunWithTimeout.java
Outdated
Show resolved
Hide resolved
alnzng
force-pushed
the
remote-bundle-processing-timeout
branch
from
7023b18 to
d59a775
Compare
xinyuiscool
reviewed
Jan 19, 2023
runners/samza/src/main/java/org/apache/beam/runners/samza/util/RunWithTimeout.java
Outdated
Show resolved
Hide resolved
alnzng
force-pushed
the
remote-bundle-processing-timeout
branch
from
d59a775 to
b058574
Compare
mynameborat
approved these changes
Jan 19, 2023
alnzng
force-pushed
the
remote-bundle-processing-timeout
branch
from
b058574 to
a677df5
Compare
alnzng
force-pushed
the
remote-bundle-processing-timeout
branch
from
a677df5 to
db7073d
Compare
3 tasks
alnzng
added a commit
to alnzng/beam
that referenced
this pull request
Jan 20, 2023
3 tasks
xinyuiscool
pushed a commit
to linkedin/beam
that referenced
this pull request
Jan 21, 2023
alnzng
added a commit
to alnzng/beam
that referenced
this pull request
Jan 25, 2023
xinyuiscool
pushed a commit
to linkedin/beam
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #25030
We have observed that some UDFs(with bugs or imported some bad third-party libs) could hang the runner and SDK harness processes in Samza portable mode. Both runner and SDK harness processes are in a zombie state and have no data processing in this case, however, the processes are not able to be shut down although Samza runner provides some built-in timeout functionality.
This change will allow the users to set a timeout for closing a remote bundle in Samza portable runner. Once the timeout occurred, the runner and SDK processes will be shut down properly by Samza's built-in task timeout functionality if enabled.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.