Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allowDiskUse to true in MongoDB bucketAuto aggregation #25013

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

johannaojeling
Copy link
Contributor

Fixes #25012 and sets allowDiskUse to true in the mongodbio.Read bucketAuto aggregation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #25013 (66776a3) into master (a5e6d90) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #25013      +/-   ##
==========================================
- Coverage   73.13%   73.13%   -0.01%     
==========================================
  Files         735      735              
  Lines       98147    98149       +2     
==========================================
  Hits        71782    71782              
- Misses      25001    25003       +2     
  Partials     1364     1364              
Flag Coverage Δ
go 51.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/io/mongodbio/read.go 30.97% <0.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johannaojeling
Copy link
Contributor Author

R: @lostluck

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit 7fd2501 into apache:master Jan 17, 2023
@johannaojeling johannaojeling deleted the fix/bucketauto-allowdiskuse branch January 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task][Go SDK]: Set allowDiskUse to true in MongoDB bucketAuto aggregation
2 participants