Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout on test_dynamic_timer_clear_then_set_timer #25009

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

damccorm
Copy link
Contributor

This test is somewhat flaky, and every time it fails it seems like it is because it times out (example). Since the timers being set are all watermark based, this doesn't indicate some sort of bad delay and bumping the timeout shouldn't do any harm.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #25009 (fbaac89) into master (e94aa45) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25009   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files         735      735           
  Lines       98147    98147           
=======================================
+ Hits        71775    71777    +2     
+ Misses      25009    25007    -2     
  Partials     1363     1363           
Flag Coverage Δ
python 82.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 74.66% <0.00%> (-0.67%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 93.13% <0.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor Author

Rerunning precommit since failure is a different known flake apache_beam.options.pipeline_options_test.PipelineOptionsTest.test_display_data (fixed this morning in #25007) - https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/26591/testReport/apache_beam.options.pipeline_options_test/PipelineOptionsTest/test_display_data/

@damccorm
Copy link
Contributor Author

Run Python PreCommit

@damccorm
Copy link
Contributor Author

R: @Abacn

@damccorm damccorm merged commit a99364c into master Jan 19, 2023
@damccorm damccorm deleted the users/damccorm/timeout branch January 19, 2023 20:13
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants