-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout on test_dynamic_timer_clear_then_set_timer #25009
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25009 +/- ##
=======================================
Coverage 73.13% 73.13%
=======================================
Files 735 735
Lines 98147 98147
=======================================
+ Hits 71775 71777 +2
+ Misses 25009 25007 -2
Partials 1363 1363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Rerunning precommit since failure is a different known flake apache_beam.options.pipeline_options_test.PipelineOptionsTest.test_display_data (fixed this morning in #25007) - https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/26591/testReport/apache_beam.options.pipeline_options_test/PipelineOptionsTest/test_display_data/ |
Run Python PreCommit |
R: @Abacn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
This test is somewhat flaky, and every time it fails it seems like it is because it times out (example). Since the timers being set are all watermark based, this doesn't indicate some sort of bad delay and bumping the timeout shouldn't do any harm.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.