Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve some errors from DoFnSignature #25001

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Jan 13, 2023

r: @kileys

When we have an anonymous class, simpleName is empty (and we weren't showing the class anyway, which is not nice).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Jan 13, 2023
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@pabloem
Copy link
Member Author

pabloem commented Jan 18, 2023

Run Java_Pulsar_IO_Direct PreCommit

1 similar comment
@pabloem
Copy link
Member Author

pabloem commented Jan 18, 2023

Run Java_Pulsar_IO_Direct PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jan 18, 2023

Run Java_Amazon-Web-Services2_IO_Direct PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jan 18, 2023

Run Java_Debezium_IO_Direct PreCommit

@pabloem pabloem merged commit 187ba47 into apache:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants