Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example checker validation for incomplete multifile examples #24993

Merged
merged 5 commits into from
Jan 13, 2023

Conversation

olehborysevych
Copy link
Collaborator

@olehborysevych olehborysevych commented Jan 13, 2023

Fixing checker for incomplete multifile examples
fixes #24994

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@@ -191,7 +191,7 @@ def get_tag(filepath) -> Optional[Tag]:

try:
return Tag(
filepath=filepath,
filepath=str(filepath),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the type of filepath that we need to cast it into a string?

@olehborysevych olehborysevych changed the title [DO NOT MERGE] Fix example checker and try to trigger incomplete file validation Fix example checker and try to trigger incomplete file validation Jan 13, 2023
@olehborysevych olehborysevych changed the title Fix example checker and try to trigger incomplete file validation Fix example checker validation for incomplete multifile examples Jan 13, 2023
@olehborysevych
Copy link
Collaborator Author

R: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@olehborysevych olehborysevych marked this pull request as ready for review January 13, 2023 14:54
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll wait for CI to pass before merging though

@damccorm damccorm merged commit 15f3717 into apache:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tour of Beam] [Bug] Example checker fails when verifying incomplete multifile examples
3 participants