-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit error for PEP 585 type hints #24986
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24986 +/- ##
===========================================
+ Coverage 58.68% 73.12% +14.44%
===========================================
Files 735 735
Lines 98146 98150 +4
===========================================
+ Hits 57594 71771 +14177
+ Misses 39188 25015 -14173
Partials 1364 1364
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run PythonDocs PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Python PreCommit |
Run PythonDocs PreCommit |
Run Python_Runners PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Run Python_Runners PreCommit |
Adds an explicit warning for users attempting to use PEP 585 type hints, directing them to use the typing module. Serves as a small improvement to the user experience while support for the new type hinting convention is designed and implemented.
Part of #23366
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.