-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sec): upgrade torch to 1.13.1 #24933
fix(sec): upgrade torch to 1.13.1 #24933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24933 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 735 735
Lines 98133 98133
=======================================
Hits 71708 71708
Misses 25065 25065
Partials 1360 1360
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
remind me after tests pass |
Ok - I'll remind @smart2pet after tests pass |
Run Inference Benchmarks |
How to do it? @AnandInguva |
This is a security vulnerabilitie fix. Do we need to do the benchmarks? |
No, it is not. I thought you included torch benchmark tests but after reviewing, these tests weren't part of that suite. So, you can ignore the |
OK. |
Reminder, please take a look at this pr: @pabloem |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
|
FYI Anand's comment was a command to the bot. |
@AnandInguva will postcommit tests exercise this change? |
Unfortunately, no. There are no tests for these examples. I thought there were but I am wrong |
What happened?
There are 1 security vulnerabilities found in torch 1.12.0.
What did I do?
Upgrade torch from 1.12.0 to 1.13.1 for vulnerability fix.
What did you expect to happen?
Clean out the insecure libs to used.
The specification of the pull request
PR Specification from OSCS