Improve Error Prone configuration #24930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24930 +/- ##
==========================================
- Coverage 73.07% 73.06% -0.01%
==========================================
Files 735 735
Lines 98133 98133
==========================================
- Hits 71708 71704 -4
- Misses 25065 25069 +4
Partials 1360 1360
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
cushon
force-pushed
the
errorprone
branch
4 times, most recently
from
7bc86e9 to
2bf2178
Compare
Pass the required `--add-exports=` flags when running on JDK 17, even if `java17Home` is unset.
| // This logic handles builds running on JDK 17, notusing -Djava17Home. | ||
| // The -J prefix is not needed if forkOptions.javaHome is unset, | ||
| // see http://github.com/gradle/gradle/issues/22747 | ||
| if (JavaVersion.VERSION_1_8.compareTo(JavaVersion.current()) < 0 |
There was a problem hiding this comment.
Is this actually specific to JDK 17? If so, we should probably do exact equality, if not the comment should be updated.
There was a problem hiding this comment.
I update the comment. The flags should be passed to all Java versions that support modules (Java 9 and up), and became mandatory for Java 17 and newer versions. So checking for version > 8 instead of version == 17 is deliberate.
|
R: @kileys could you take a look since this is a Java 17 change? |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run Java PreCommit |
| @@ -778,6 +778,7 @@ class BeamModulePlugin implements Plugin<Project> { | |||
| // Disabling checks since this property is only used for Jenkins tests | |||
| // https://github.com/tbroyer/gradle-errorprone-plugin#jdk-16-support | |||
| options.errorprone.errorproneArgs.add("-XepDisableAllChecks") | |||
| // The -J prefix is needed to workaround https://github.com/gradle/gradle/issues/22747 | |||
There was a problem hiding this comment.
Is this the right issue?
Thanks, that should have been gradle/gradle#22746, I pushed a fix
|
LGTM |
Pass the required
--add-exports=flags whenever the current JDK supports them, instead of relying onjava17Homebeing set.Also upgrade the Error Prone version, and remove obsolete 'errorproneJavac' configuration.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.