Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground][Frontend] Run timer fix; CodeRunner and OutputType extraction. #24871

Merged
merged 20 commits into from
Jan 19, 2023

Conversation

nausharipov
Copy link
Contributor

@nausharipov nausharipov commented Jan 4, 2023

Resolves #24617
Resolves #24691


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@nausharipov
Copy link
Contributor Author

R: @alexeyinkin

@nausharipov
Copy link
Contributor Author

R: @damondouglas

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damccorm LGTM Apologies just saw merge conflicts.

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nausharipov Resolve the merge conflicts and reassign to me. Thank you!

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloem LGTM

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 1c4e424 into apache:master Jan 19, 2023
@nausharipov nausharipov deleted the issue24617_timer_fix branch March 28, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants