Modify windmill DirectStreamObserver to call isReady only every 10 messages by default #24853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @reuvenlax |
|
This is motivated by excessive onReady overhead observed in #24836 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
reuvenlax
reviewed
Jan 5, 2023
| firstMessage = false; | ||
| outboundObserver.onNext(value); | ||
| return; | ||
| synchronized (lock) { |
There was a problem hiding this comment.
what's the reason to move the lock to outside of the while loop?
There was a problem hiding this comment.
was thinking it would reduce grabbing/releasing, since other callers will be waiting on phaser anyway
But on second thought, that only reduces lock/unlock on timeouts and it could have weird interactions wiating on phaser and blocking onError/onCompleted. Changing it back.
…ssages by default. This provides more output buffering which ensures that output is not throttled on synchronization when message sizes exceed 32KB grpc isready limit.
|
Run Dataflow ValidatesRunnerStreaming |
|
Run Dataflow Streaming ValidatesRunner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides more output buffering which ensures that output is not throttled on synchronization when message sizes exceed 32KB grpc isready limit.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.