-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEAM-13261 added max connections setting #24851
BEAM-13261 added max connections setting #24851
Conversation
R: @jbonofre |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Just a small note, ptal
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
Outdated
Show resolved
Hide resolved
This PR broke Python postcommi's jdbc xlang test: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Python38/3630/
|
@@ -174,6 +174,12 @@ protected JdbcIO.DataSourceConfiguration getDataSourceConfiguration() { | |||
.collect(Collectors.toList()); | |||
dataSourceConfiguration = dataSourceConfiguration.withConnectionInitSqls(initSqls); | |||
} | |||
|
|||
@Nullable Integer maxConnections = config.getInt32("maxConnections"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should tolerate the incoming schema not containing this field for backward compatibility
Adds max pool connections as a configurable parameter while creating Datasource.
Task: #21200
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.