Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEAM-13261 added max connections setting #24851

Merged

Conversation

pas725
Copy link
Contributor

@pas725 pas725 commented Jan 1, 2023

Adds max pool connections as a configurable parameter while creating Datasource.

Task: #21200


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@pas725
Copy link
Contributor Author

pas725 commented Jan 1, 2023

R: @jbonofre
R: @timrobertson100

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM
Just a small note, ptal

@aromanenko-dev aromanenko-dev merged commit 869150c into apache:master Jan 17, 2023
@Abacn
Copy link
Contributor

Abacn commented Jan 18, 2023

This PR broke Python postcommi's jdbc xlang test: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Python38/3630/

      with ExternalTransform.service(self._expansion_service) as service:
        response = service.Expand(request)
        if response.error:
>         raise RuntimeError(response.error)
E         RuntimeError: java.lang.IllegalArgumentException: Cannot find field maxConnections in schema Fields:

@@ -174,6 +174,12 @@ protected JdbcIO.DataSourceConfiguration getDataSourceConfiguration() {
.collect(Collectors.toList());
dataSourceConfiguration = dataSourceConfiguration.withConnectionInitSqls(initSqls);
}

@Nullable Integer maxConnections = config.getInt32("maxConnections");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should tolerate the incoming schema not containing this field for backward compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants