Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message for mismatched pipelines #24834

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

zhenglin-charlie-li
Copy link
Contributor

improve error message for mismatched pipelines

fix issue: #18040


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #24834 (fee80ef) into master (889fd8b) will increase coverage by 7.82%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #24834      +/-   ##
==========================================
+ Coverage   65.19%   73.01%   +7.82%     
==========================================
  Files         731      734       +3     
  Lines       97960    98104     +144     
==========================================
+ Hits        63861    71635    +7774     
+ Misses      32743    25113    -7630     
  Partials     1356     1356              
Flag Coverage Δ
python 82.67% <100.00%> (+11.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/util.py 96.24% <100.00%> (ø)
...hon/apache_beam/runners/direct/test_stream_impl.py 93.28% <0.00%> (-0.75%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 81.74% <0.00%> (-0.15%) ⬇️
...am/testing/benchmarks/cloudml/criteo_tft/criteo.py 0.00% <0.00%> (ø)
...chmarks/cloudml/cloudml_benchmark_constants_lib.py 100.00% <0.00%> (ø)
...m/testing/benchmarks/cloudml/pipelines/workflow.py 6.94% <0.00%> (ø)
...ks/python/apache_beam/runners/worker/operations.py 74.32% <0.00%> (+0.14%) ⬆️
sdks/python/apache_beam/transforms/environments.py 88.26% <0.00%> (+0.29%) ⬆️
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.48%) ⬆️
... and 161 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@zhenglin-charlie-li
Copy link
Contributor Author

R: @tvalentyn

could I ask a question that why there are two checks were failed?

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

Apologies for the long response, I was OOO for a bit. Thanks for the fix!

Precommit errors are most likely a flake, we can re-run the suite. Lint errors is visible if you follow the "Details" -> Console Output link. The error is:

apache_beam  conftest.py  gen_protos.py  setup.py
Running pylint...
************* Module apache_beam.transforms.util
apache_beam/transforms/util.py:238:0: C0301: Line too long (88/80) (line-too-long)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, -0.00)

@tvalentyn
Copy link
Contributor

tvalentyn commented Jan 19, 2023

see also: https://s.apache.org/beam-python-dev-wiki which talks about how to run linter locally during development.

sdks/python/apache_beam/transforms/util.py Outdated Show resolved Hide resolved
@tvalentyn
Copy link
Contributor

Linter errors should be fixed, we can merge once tests run.

@tvalentyn tvalentyn merged commit 428ec97 into apache:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants