Add gradle files for typescript containers and update the version info. #24827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container are now built with ./gradlew ":sdks:typescript:container:docker" just like all other SDKs and they will be pushed as part of the release process.
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #24827 +/- ##
==========================================
- Coverage 73.12% 65.19% -7.94%
==========================================
Files 731 731
Lines 97945 97945
==========================================
- Hits 71620 63851 -7769
- Misses 24971 32740 +7769
Partials 1354 1354
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
damccorm
reviewed
Dec 29, 2022
sdks/typescript/build.gradle
Outdated
| // Build artifact | ||
| exec { | ||
| executable 'sh' | ||
| args '-c', "npm run build && npm pack --pack-destination ${buildDir}" |
There was a problem hiding this comment.
Do we need an npm install here?
sdks/typescript/container/boot.go
Outdated
| var wg sync.WaitGroup | ||
| wg.Add(len(workerIds)) | ||
| for _, workerId := range workerIds { | ||
| go func(workerId string) { | ||
| log.Printf("Executing: python %v", strings.Join(args, " ")) | ||
| log.Fatalf("User program exited: %v", execx.ExecuteEnv(map[string]string{"WORKER_ID": workerId}, "npx", args...)) | ||
| workerArgs := append(append([]string{}, args...), "--id=" + workerId) |
There was a problem hiding this comment.
Looks like this file might need a go fmt
damccorm
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container are now built with
just like all other SDKs and they will be pushed as part of the release process.
Also fixes issue with typescript sibling sdks.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.