Various cleanups to the typescript SDK. #24825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better errors for bad serialization imports. * Semver-correct version for fake worker package. * Package source into temporary directory. * Allow "latest" as a xlang beam jar version for non-released SDKs. * Less verbose logging.
damccorm
approved these changes
Dec 29, 2022
Comment on lines
+348
to
+361
| const metadata = await new Promise<string>((resolve, reject) => { | ||
| let data = ""; | ||
| https.get(medatadataUrl, (res) => { | ||
| res.on("data", (chunk) => { | ||
| data += chunk; | ||
| }); | ||
| res.on("end", () => { | ||
| resolve(data); | ||
| }); | ||
| res.on("error", (e) => { | ||
| reject(e); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Optional: It might be worth considering a http client library that can do things like handle retries/redirects and will patch responses together for us - I'm partial to https://github.com/microsoft/typed-rest-client (the Http client, not the Rest client in this case), but there are plenty of options out there.
There was a problem hiding this comment.
I'm going to avoid taking on another dependency right now, but that's good to keep in mind if we end up needing to make these kinds of calls more often.
robertwb
commented
Dec 29, 2022
Comment on lines
+348
to
+361
| const metadata = await new Promise<string>((resolve, reject) => { | ||
| let data = ""; | ||
| https.get(medatadataUrl, (res) => { | ||
| res.on("data", (chunk) => { | ||
| data += chunk; | ||
| }); | ||
| res.on("end", () => { | ||
| resolve(data); | ||
| }); | ||
| res.on("error", (e) => { | ||
| reject(e); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I'm going to avoid taking on another dependency right now, but that's good to keep in mind if we end up needing to make these kinds of calls more often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.