-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix POM of beam-sdks-java-core #24760
Conversation
R: @pabloem |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Run GoPortable PreCommit |
Run Java_Pulsar_IO_Direct PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #24760 +/- ##
=======================================
Coverage 73.34% 73.34%
=======================================
Files 721 721
Lines 97224 97224
=======================================
+ Hits 71306 71310 +4
+ Misses 24568 24564 -4
Partials 1350 1350
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Java_Pulsar_IO_Direct PreCommit |
Run Java_Kafka_IO_Direct PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Just a quick question, ptal
As of #24271 the pom of
beam-sdks-java-core
is broken. There's no version specified fororg.json:json
inBeamModulePlugin
:This sets the version to the transitive version resolved through
com.github.erosb:everit-json-schema:1.14.1
.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.