Adding watermark support to DebeziumIO transform #24757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r: @chamikaramj |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
r: @chamikaramj would you be ablet o help out? : ) |
johnjcasey
reviewed
Dec 28, 2022
| @@ -78,6 +79,18 @@ public static Schema.FieldType beamSchemaTypeFromKafkaType( | |||
| } | |||
| } | |||
|
|
|||
| public static Instant debeziumRecordInstant(SourceRecord record) { | |||
| if (!record.valueSchema().type().equals(org.apache.kafka.connect.data.Schema.Type.STRUCT) | |||
There was a problem hiding this comment.
Can we add a test to verify this behavior as well?
|
thanks for the review @johnjcasey ! I've added the test. Can you take a look please? : ) |
|
broken suite is unrelated : ) |
|
ptal : D |
|
@johnjcasey ptal : ) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had no watermark support before, which is a serious problem : /
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.