Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] update links from absolute to relative in md files #24747

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Dec 21, 2022

  • update links from absolute path to relative one in md files

after:
product_links

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@bullet03 bullet03 marked this pull request as ready for review December 21, 2022 12:47
@bullet03 bullet03 marked this pull request as draft December 21, 2022 12:49
@bullet03 bullet03 marked this pull request as ready for review December 22, 2022 16:57
@bullet03
Copy link
Contributor Author

R: @aromanenko-dev, coould you, please help with review?

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@aromanenko-dev
Copy link
Contributor

aromanenko-dev commented Dec 27, 2022

@bullet03 Is it expected behaviour that it add index.html for relative links (e.g. see an attached screenshot)? I didn't notice the same behaviour for absolute links as it was before?
Also, if I drop index.html from the URL in browser, it got broken.

Screenshot 2022-12-27 at 16 12 52

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check if the old style links (without index.html in the end) are still working

@bullet03
Copy link
Contributor Author

@bullet03 Is it expected behaviour that it add index.html for relative links (e.g. see an attached screenshot)? I didn't notice the same behaviour for absolute links as it was before? Also, if I drop index.html from the URL in browser, it got broken.

Screenshot 2022-12-27 at 16 12 52

Had a consultation with devops from apache-beam. index.html is added to the end of the files in staging automatically. Links don't work without this part at the end only on staging. It worked like this before: here are some examples with staging from different PRs, one from December and another one from February. index.html part was present.

8
9

@bullet03
Copy link
Contributor Author

Please, check if the old style links (without index.html in the end) are still working

Since the path is relative, index.html in the end won't affect localhost or prod, just only staging.
For instance path like /get-started/try-beam-playground/ will lead to localhost:1313/get-started/try-beam-playground on localhost, to https://beam.apache.org/get-started/try-beam-playground on production and to http://apache-beam-website-pull-requests.storage.googleapis.com/24427/get-started/try-beam-playground/index.html on staging.

Right now there are absolute links like https://beam.apache.org/get-started/try-beam-playground on both of 3 environments. If I click on such a link on localhost, I won't get to another localhost page, but to production site instead.

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bullet03 Thanks for verification! It would be great to have the same behaviour everywhere - locally, on staging and on production - for the future, if it's possible, of course, to avoid such confusion.

LGTM expecting that it just drops https://beam.apache.org/ from absolute website links.

@aromanenko-dev aromanenko-dev merged commit 0f423dd into apache:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants