-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Website] update links from absolute to relative in md files #24747
[Website] update links from absolute to relative in md files #24747
Conversation
R: @aromanenko-dev, coould you, please help with review? |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
@bullet03 Is it expected behaviour that it add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check if the old style links (without index.html
in the end) are still working
Had a consultation with devops from apache-beam. |
Since the path is relative, Right now there are absolute links like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bullet03 Thanks for verification! It would be great to have the same behaviour everywhere - locally, on staging and on production - for the future, if it's possible, of course, to avoid such confusion.
LGTM expecting that it just drops https://beam.apache.org/
from absolute website links.
after:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.