Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jamm on -javaagent instead of classpath #24738

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

apilloud
Copy link
Member

This improves test coverage of the javaagent path, which is what is used on actual workers.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Dec 21, 2022
@lukecwik
Copy link
Member

Note that this only changes the testing for JMH benchmarks which is fine if you want to update that.

Note that there is existing coverage that tests the docker images, here is a code pointer:

public void testJammAgentAvailable() throws Exception {

@apilloud apilloud merged commit fde81f8 into apache:master Dec 21, 2022
@apilloud apilloud deleted the javaagent branch December 21, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants