Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] update links with 404 status code #24635

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Dec 12, 2022


before/after:
404_1
404_2
404_3
404_4
404_5


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@bullet03 bullet03 force-pushed the website-update-error-links branch 2 times, most recently from ec563bd to 75a3282 Compare December 13, 2022 15:37
@bullet03 bullet03 force-pushed the website-update-error-links branch from 75a3282 to 4764f0e Compare December 21, 2022 11:10
@bullet03 bullet03 marked this pull request as ready for review December 21, 2022 15:38
@bullet03
Copy link
Contributor Author

R: @aromanenko-dev, could you, kindly, help with review?

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aromanenko-dev aromanenko-dev merged commit 3f67b2c into apache:master Dec 22, 2022
@aromanenko-dev
Copy link
Contributor

@bullet03 Do you know if there is a way to detect broken links automatically, e.g. before publishing website? IIRC, it was something like this before.

@bullet03
Copy link
Contributor Author

LGTM

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants