Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Force discarding mode in with_fanout without rewindowing." #24378

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Nov 28, 2022

Reverts #23828

Reason: caused a memory increase for one of internal customers. Reverting while the investigation is happening.

Original issue: #20528

@tvalentyn
Copy link
Contributor Author

R: @robertwb @kerrydc

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #24378 (2897e1a) into master (1115154) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24378      +/-   ##
==========================================
- Coverage   73.36%   73.35%   -0.02%     
==========================================
  Files         718      718              
  Lines       97034    97033       -1     
==========================================
- Hits        71193    71180      -13     
- Misses      24511    24523      +12     
  Partials     1330     1330              
Flag Coverage Δ
python 82.99% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/core.py 92.90% <ø> (+0.36%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 90.97% <0.00%> (-0.76%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...ython/apache_beam/io/gcp/bigquery_read_internal.py 57.21% <0.00%> (-0.49%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.42% <0.00%> (-0.38%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (-0.33%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery.py 71.11% <0.00%> (-0.24%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn tvalentyn merged commit 3477d4a into master Nov 28, 2022
@tvalentyn tvalentyn deleted the revert-23828-fanout branch November 28, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants