Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow cron syntax #24376

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix workflow cron syntax #24376

merged 1 commit into from
Nov 28, 2022

Conversation

damccorm
Copy link
Contributor

GitHub Actions doesn't support the same cron syntax as Jenkins - https://docs.github.com/en/actions/migrating-to-github-actions/migrating-from-jenkins-to-github-actions#scheduling-a-pipeline-to-run-with-cron

This fixes the problem leading to failed runs like https://github.com/apache/beam/actions/runs/3565663232

I also manually added my own jitters by generating random values for the day/hour fields (so this maintains parity with using H)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

R: @AnandInguva @pabloem @alxmrs

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AnandInguva
Copy link
Contributor

Thanks!

@damccorm damccorm merged commit 1115154 into master Nov 28, 2022
@damccorm damccorm deleted the users/damccorm/fix-cron-syntax branch November 28, 2022 15:36
@pabloem
Copy link
Member

pabloem commented Nov 28, 2022

aw thanks <3

ruslan-ikhsan pushed a commit to ruslan-ikhsan/beam that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants