Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable streaming runner v2 tests that were forgotten to be enabled. #24321

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Nov 22, 2022

These tests are run internally in Google and have been passing for quite some time.

Fixes #19957
Fixes #20726
Fixes #20601
Fixes #20734


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@lukecwik
Copy link
Member Author

R: @apilloud
CC: @reuvenlax

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

These tests are run internally on Google and have been passing for quite some time.

Fixes apache#19957
Fixes apache#20726
Fixes apache#20601
Fixes apache#20734
@lukecwik
Copy link
Member Author

Run Java Dataflow V2 ValidatesRunner Streaming

Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukecwik
Copy link
Member Author

Run Java Dataflow V2 ValidatesRunner Streaming

@lukecwik
Copy link
Member Author

Run Java Dataflow V2 ValidatesRunner Streaming

@lukecwik lukecwik merged commit 3b7e181 into apache:master Nov 24, 2022
ruslan-ikhsan pushed a commit to ruslan-ikhsan/beam that referenced this pull request Nov 30, 2022
…pache#24321)

* Enable streaming runner v2 tests that were forgotten to be enabled.

These tests are run internally on Google and have been passing for quite some time.

Fixes apache#19957
Fixes apache#20726
Fixes apache#20601
Fixes apache#20734

* Explicitly enable streaming engine for runner based autosharding test
@lukecwik lukecwik deleted the 19957 branch December 2, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment