-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Standardize typehint
in Python documention and docstrings
#23984
Conversation
Thanks for the fix. There is a test failure about assertion to error message:
|
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report
@@ Coverage Diff @@
## master #23984 +/- ##
==========================================
+ Coverage 73.45% 73.47% +0.02%
==========================================
Files 709 709
Lines 95971 96048 +77
==========================================
+ Hits 70491 70575 +84
+ Misses 24163 24156 -7
Partials 1317 1317
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thanks @Abacn ,i fixed it. |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
I think we may want to standardize on "type hint" in documentation and "typehint" for code. For reference: PEP 484 uses "type hint". |
I'm going to propose we switch to "type hints" in documentation. I'll raise on dev@ to see if there are any objections. Can we hold on this for a couple of days? |
Sure @TheNeuralBit ,
Sure @TheNeuralBit ,i will make the changes once you confirm them. 👍 |
Thanks! How about if we don't hear any objection by Wednesday (9 November) we go ahead with switching to "type hints" |
Reminder, please take a look at this pr: @AnandInguva @ahmedabu98 |
Hi, I think based on the discussion the Beam dev list(https://lists.apache.org/[email protected]:lte=1M:typehint)
Thanks for the changes. |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
|
waiting on author |
@TheNeuralBit , any update on this ? |
Please look at #23984 (comment) |
Thanks ,i will do it. |
Reminder, please take a look at this pr: @tvalentyn @chamikaramj |
waiting on author |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
|
waiting on author |
@ayushthe1 friendly ping:). Any update on this? |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
fixes #23950
Currently 3 different formats
(type-hints , type hints, type hints )
are used to represent "typehints" across the documentation and docstrings.This creates confusion ,so this pr aims to standardize all occurences across documentation and docstrings by choosing
typehints
as the default format and replacing all the other formats with this.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.