Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sibling protocol for Typescript. #23975

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Nov 3, 2022

Though there are various worker thread libraries in Node.js, the lack of a shared memory model makes it difficult to share caches, negating most of the benefit of trying to run multiple threads in the same process. In addition, having multiple independent workers connect to the control service is simpler (and possibly more efficient) than adding a proxying service within the javascript process.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Though there are various worker thread libraries in
Node.js, the lack of a shared memory model makes it
difficult to share caches, negating most of the benefit
of trying to run multiple threads in the same process.
In addition, having multiple independent workers connect
to the control service is simpler (and possibly more
efficient) than adding a proxying service within the
javascript process.
@robertwb
Copy link
Contributor Author

robertwb commented Nov 3, 2022

R: @pskevin

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@robertwb
Copy link
Contributor Author

Ping?

@pskevin
Copy link
Contributor

pskevin commented Dec 22, 2022

Thanks for the nudge! LGTM.

@robertwb robertwb merged commit c5c5b35 into apache:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants