Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BatchConverter inference errors more helpful #23965

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

TheNeuralBit
Copy link
Member

Fixed #23953

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

R: @pabloem

@pabloem
Copy link
Member

pabloem commented Nov 3, 2022

LGTM thanks Brian : )

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #23965 (704c0ff) into master (85b6b64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #23965   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files         707      707           
  Lines       95856    95865    +9     
=======================================
+ Hits        70487    70495    +8     
- Misses      24052    24053    +1     
  Partials     1317     1317           
Flag Coverage Δ
python 83.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/core.py 92.90% <100.00%> (+0.03%) ⬆️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) ⬇️
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.41% <0.00%> (+0.08%) ⬆️
.../apache_beam/typehints/arrow_type_compatibility.py 86.25% <0.00%> (+0.62%) ⬆️
sdks/python/apache_beam/typehints/batch.py 91.08% <0.00%> (+0.63%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.77% <0.00%> (+1.26%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the python label Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@TheNeuralBit
Copy link
Member Author

Run Python PreCommit

@TheNeuralBit TheNeuralBit merged commit 7da182a into apache:master Nov 4, 2022
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Nov 11, 2022
* Add better error messages for BatchConverter inference failure

* Remove extraneous 'BatchDoFn' from class names

* yapf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants