-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CdapIO] Add readme for CdapIO. Update readme for SparkReceiverIO. #23959
Conversation
33b5141
to
5d9563a
Compare
Run Whitespace PreCommit |
Run Java PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @johnjcasey We've published README for CDAP and SparkReceiver IOs PR. It's ready for review. Thank you for your attention! |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
Just a small note
retest this please |
…pache#23959) * Add README for CdapIO. Update README for SparkReceiverIO. * Set export javadoc true for cdap and sparkreceiver * Updates to CdapIO and SparkReceiverIO readmes * Add manual how to add support for Batch and Streaming Cdap plugins. * Add manual how to add support for Spark Receiver. * Fix whitespace * updates to CDAP and SparkReceiver readme files * Updated CDAP readme * Fix links in readme Co-authored-by: Alex Kosolapov <[email protected]>
Resolves #24961
Resolves #24960
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.