Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CdapIO] Add readme for CdapIO. Update readme for SparkReceiverIO. #23959

Merged
merged 9 commits into from
Dec 5, 2022

Conversation

Amar3tto
Copy link
Contributor

@Amar3tto Amar3tto commented Nov 3, 2022

Resolves #24961
Resolves #24960


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Amar3tto
Copy link
Contributor Author

Run Whitespace PreCommit

@Amar3tto
Copy link
Contributor Author

Run Java PreCommit

@Amar3tto Amar3tto marked this pull request as ready for review November 29, 2022 11:43
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @apilloud for label java.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@elizaveta-lomteva
Copy link
Contributor

R: @johnjcasey
R: @chamikaramj
R: @aromanenko-dev

We've published README for CDAP and SparkReceiver IOs PR. It's ready for review.

Thank you for your attention!

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM
Just a small note

sdks/java/io/cdap/README.md Outdated Show resolved Hide resolved
@AKosolapov
Copy link
Contributor

retest this please

@aromanenko-dev aromanenko-dev merged commit a9dcf95 into apache:master Dec 5, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
…pache#23959)

* Add README for CdapIO. Update README for SparkReceiverIO.

* Set export javadoc true for cdap and sparkreceiver

* Updates to CdapIO and SparkReceiverIO readmes

* Add manual how to add support for Batch and Streaming Cdap plugins.

* Add manual how to add support for Spark Receiver.

* Fix whitespace

* updates to CDAP and SparkReceiver readme files

* Updated CDAP readme

* Fix links in readme

Co-authored-by: Alex Kosolapov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants