-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensorflow object detection example using RunInference #23831
Conversation
The Workflow run is cancelling this PR. It is an earlier duplicate of 1729654 run. |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
1 similar comment
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Codecov Report
@@ Coverage Diff @@
## master #23831 +/- ##
==========================================
- Coverage 73.91% 73.75% -0.16%
==========================================
Files 703 708 +5
Lines 95082 95529 +447
==========================================
+ Hits 70278 70457 +179
- Misses 23493 23761 +268
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer |
@damccorm Andy started this and this was used to provide benchmarks for NVIDIA and Dataflow blog. What should we do about this PR? |
Is there any harm in adding this example? Especially to showcase TF w/ GPUs? (Though we don't have to do it for the sake of adding more. I'll leave the decision up to y'all.) |
I don't mind adding it, but I'm not sure that it adds a ton of value given that we now have #23456; I think it would take at least a little additional work to get this ready (we'd at least need a test) and I'd probably vote we focus on other things. If either of you feels differently and wants to take it forward, I'm happy to review and don't have a problem adding it |
I agree that the incremental value-add (especially in the short-term) isn't that high. I don't know the details of your bandwidths, so if there are higher priorities, I think it's ok to table this. We can pick this up from the backlog (keep this draft PR or create an issue?) if there's more time in the future, or a new contributor wants to work on this. |
Keeping it in draft seems fine to me, its got all the context we'd need to pick it back up |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.