-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go SDK] Add fake impulse for inputs in Xlang Transform #23383
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
CC: @lostluck |
Run XVR_Flink PostCommit |
Run XVR_Dataflow PostCommit |
Run Go Flink ValidatesRunner |
Run Go PostCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll merge once we have the PostCommit tests passing.
This should resolve the evident issue in #22931, but there's another Schema/Logical type issue that follows up after and blocks python still. Ritesh is looking into them still. |
Go Flink ValidatesRunner Tests |
Okay, it is affecting other tests. I'm going to filter this change only for python external transforms. |
Run XVR_Flink PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #23383 +/- ##
==========================================
- Coverage 73.40% 73.40% -0.01%
==========================================
Files 718 718
Lines 95652 95630 -22
==========================================
- Hits 70211 70194 -17
+ Misses 24130 24125 -5
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Go Flink ValidatesRunner |
Run Go PostCommit |
Run Go PreCommit |
Run XVR_Flink PostCommit |
Run XVR_Dataflow PostCommit |
Looks like the postcommit failure is due to timeout? |
Run Go PostCommit |
Run Go PostCommit |
Run Go Postcommit |
|
The Postcommit failures are on unrelated pipelines and due to quota issues w/apache-beam-testing on Dataflow (ip addresses of all things). Approved and merging. |
Python External Transform requires producers of input PCollection in the expansion request. Currently, we just pass the transform to be expanded and its associated input and output in Expansion Request. This PR adds a fake impulse to each input PCollection so that Python External Transform can expand transforms from Go.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.