Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK] Add fake impulse for inputs in Xlang Transform #23383

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Sep 27, 2022

Python External Transform requires producers of input PCollection in the expansion request. Currently, we just pass the transform to be expanded and its associated input and output in Expansion Request. This PR adds a fake impulse to each input PCollection so that Python External Transform can expand transforms from Go.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@riteshghorse riteshghorse changed the title ]add fake impulse [Go SDK] Add fake impulse for inputs in Xlang Transform Sep 27, 2022
@github-actions github-actions bot added the go label Sep 27, 2022
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@riteshghorse
Copy link
Contributor Author

CC: @lostluck

@lostluck
Copy link
Contributor

Run XVR_Flink PostCommit

@lostluck
Copy link
Contributor

Run XVR_Dataflow PostCommit

@lostluck
Copy link
Contributor

Run Go Flink ValidatesRunner

@lostluck
Copy link
Contributor

Run Go PostCommit

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge once we have the PostCommit tests passing.

@lostluck
Copy link
Contributor

lostluck commented Sep 27, 2022

This should resolve the evident issue in #22931, but there's another Schema/Logical type issue that follows up after and blocks python still. Ritesh is looking into them still.

@lostluck
Copy link
Contributor

Go Flink ValidatesRunner Tests

@riteshghorse
Copy link
Contributor Author

Okay, it is affecting other tests. I'm going to filter this change only for python external transforms.

@riteshghorse
Copy link
Contributor Author

Run XVR_Flink PostCommit

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #23383 (dabe9f0) into master (c36077a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #23383      +/-   ##
==========================================
- Coverage   73.40%   73.40%   -0.01%     
==========================================
  Files         718      718              
  Lines       95652    95630      -22     
==========================================
- Hits        70211    70194      -17     
+ Misses      24130    24125       -5     
  Partials     1311     1311              
Flag Coverage Δ
go 50.87% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/xlangx/expand.go 0.00% <0.00%> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 74.66% <0.00%> (-2.00%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.71%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.62% <0.00%> (-0.48%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.13%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 94.34% <0.00%> (-0.03%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (ø)
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.43% <0.00%> (+0.38%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riteshghorse
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@riteshghorse
Copy link
Contributor Author

Run Go PostCommit

@riteshghorse
Copy link
Contributor Author

Run Go PreCommit

@riteshghorse
Copy link
Contributor Author

Run XVR_Flink PostCommit

@riteshghorse
Copy link
Contributor Author

Run XVR_Dataflow PostCommit

@riteshghorse
Copy link
Contributor Author

riteshghorse commented Sep 28, 2022

@riteshghorse
Copy link
Contributor Author

Run Go PostCommit

@riteshghorse
Copy link
Contributor Author

Run Go PostCommit

@lostluck
Copy link
Contributor

Run Go Postcommit

@riteshghorse
Copy link
Contributor Author

TestWindowSums_GBK and TestValidateWindowedSideInputs fails in Job Pending stage on dataflow. Probably the timeout error

@lostluck
Copy link
Contributor

lostluck commented Oct 4, 2022

The Postcommit failures are on unrelated pipelines and due to quota issues w/apache-beam-testing on Dataflow (ip addresses of all things). Approved and merging.

@lostluck lostluck merged commit fd45479 into apache:master Oct 4, 2022
@riteshghorse riteshghorse deleted the pyXlang branch October 12, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants