Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] update check-links #22221

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

bullet03
Copy link
Contributor

@bullet03 bullet03 commented Jul 11, 2022

  • update check-links.sh script
  • add func to find absolute links, leading to prod and staging
  • add manually verified list with links that should be ignored
  • sort invalid links by error code status

before:
before_ch
after:

  • checking absolute production links
    after_ch_1
    after_ch_3
  • checking staging links
    after_ch_2
    after_ch_4
  • invalid links sorted by error status code
    after_ch_5

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@bullet03 bullet03 force-pushed the website-update-check-links branch 6 times, most recently from 264efad to 22b6078 Compare July 18, 2022 12:33
@bullet03 bullet03 force-pushed the website-update-check-links branch 21 times, most recently from d042e10 to e141a0f Compare July 28, 2022 11:41
@bullet03 bullet03 force-pushed the website-update-check-links branch 2 times, most recently from 74b1288 to 33489bf Compare July 28, 2022 12:32
@bullet03 bullet03 force-pushed the website-update-check-links branch 3 times, most recently from a9cbbf6 to 6494abd Compare September 9, 2022 11:33
@bullet03 bullet03 force-pushed the website-update-check-links branch 7 times, most recently from f880206 to 6e735bd Compare October 28, 2022 10:13
@bullet03 bullet03 force-pushed the website-update-check-links branch from 6e735bd to 6fedfe2 Compare October 31, 2022 09:06
@bullet03 bullet03 force-pushed the website-update-check-links branch 2 times, most recently from dbfd937 to 86eda8d Compare December 15, 2022 12:32
@bullet03 bullet03 force-pushed the website-update-check-links branch 8 times, most recently from 7adcdb3 to a3e0918 Compare December 21, 2022 19:10
@bullet03 bullet03 marked this pull request as ready for review December 22, 2022 16:56
@bullet03
Copy link
Contributor Author

R: @aromanenko-dev, could you kindly help with review?

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the naming of methods and variable names.

Do we run this script automatically? What is an example of the output?

website/www/check-links.sh Outdated Show resolved Hide resolved
website/www/check-links.sh Outdated Show resolved Hide resolved
@bullet03 bullet03 force-pushed the website-update-check-links branch from a3e0918 to a43b834 Compare December 28, 2022 08:23
@bullet03
Copy link
Contributor Author

Please, check the naming of methods and variable names.

Do we run this script automatically? What is an example of he output?

  • Yes, script is run automatically
  • Example of the output:
    5
    6
    7

Example of the output is also provided in the description of the PR.

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aromanenko-dev aromanenko-dev merged commit 994f733 into apache:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants