BEAM-13765 missing PAssert methods #16668

mkuthan · 2022-01-31T20:40:33Z

It seems IterableAssert and SingletonAssert should provide identical pane assertions. But
there is no inOnlyPane for InterableAssert and no inWindow for SingletonAssert.
This is almost a mechanical change, nothing really new IMHO.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

`ValidatesRunner` compliance status (on master branch)

Lang	ULR	Twister2
Go	---	---
Java
Python	---	---
XLang		---

Examples testing status on various runners

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---	---	---	---	---	---	---
Java	---		---	---	---	---	---
Python	---	---	---	---	---	---	---
XLang	---	---	---	---	---	---	---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go	Java	Python

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

mkuthan · 2022-01-31T20:49:18Z

R: @kennknowles - you are the author of the most assertions in the codebase, could you look at my supplement, please?

Thanks a lot!

mkuthan · 2022-02-01T07:28:21Z

retest this please

kennknowles · 2022-02-01T13:57:20Z

sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java

+     * Creates a new {@link SingletonAssert} like this one, but with the assertion restricted to
+     * only run on the provided window.
+     *
+     * <p>The assertion will concatenate all panes present in the provided window if the {@link


This assertion sort of applies to multiple values inherently, so that is probably why it wasn't present.

Hmm, 'inWindow' assertion means that only window boundaries should be checked but I don't care if the element is early, on-time or late. If there is a single element in the result the SingletonAssert is needed.

For example (Scio like DSL for testing):

results should inWindow("00:00:00", "00:10:00") { containSingleValue("00:09:59.999", "foo") // singleton assert }

kennknowles · 2022-02-01T14:00:56Z

sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java

+     * @return a new {@link IterableAssert} like this one but with the assertion only applied to the
+     *     specified window.
+     */
+    IterableAssert<T> inOnlyPane(BoundedWindow window);


I double checked that adequate validation is in place to ensure this is not applied when there is more than one pane. Curiously the validation occurs on the PaneInfo of emitted elements rather than by examining the trigger. But anyhow this one seems safe enough.

What kind of validation do you mean? If I understood the code, the assertions like inOnTimePane, inLatePane, or inWindow apply a simple filter using PaneInfo to ensure that only data from given pane is passed for further assertions.

The PaneExtractors.onlyPane is somehow special because it might throw an AssertionError, it seems to be correct, the filtering is not enough to ensure that it is the only pane.

The condition for "only pane" is defined as not(!pane.isFirst() || !pane.isLast()). Wouldn't it be more straightforward to throw an error if pane.index > 0?

y1chi · 2022-02-11T00:42:20Z

@kennknowles PTAL

kennknowles · 2022-02-11T17:41:06Z

Run Java PreCommit

kennknowles · 2022-02-11T17:41:13Z

Run Java_Examples_Dataflow_Java17 PreCommit

aaltay · 2022-02-25T00:59:57Z

Are the tests failing because of this change? Or are they unrelated?

mkuthan · 2022-02-25T08:19:48Z

Are the tests failing because of this change? Or are they unrelated?

Very unlikely. I checked one of the failed test and the error seems to be unrelated:

https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/4648/testReport/junit/org.apache.beam.sdk.io.gcp.bigquery/BigQueryServicesImplTest/testInsertWithinRequestByteSizeLimits/

aaltay · 2022-02-25T16:40:47Z

Run Java PreCommit

mkuthan · 2022-03-07T08:28:19Z

@aaltay - What should I do to make the PR ready to merge?

aaltay · 2022-03-07T16:27:46Z

java precommit is failing. We need that to pass. You can rerun it by commenting the phrase but please first check to see if they are related to this PR.

mkuthan · 2022-03-07T20:09:41Z

@aaltay I've synchronized my branch with the upstream and all checks are green now, except tests on MacOs. Perhaps it's well known issue, the tests have not been started for more than hour - actions/runner-images#841

aaltay · 2022-03-08T00:02:42Z

@aaltay I've synchronized my branch with the upstream and all checks are green now, except tests on MacOs. Perhaps it's well known issue, the tests have not been started for more than hour - actions/virtual-environments#841

It looks like all tests passed.

aaltay · 2022-03-08T00:04:17Z

@kennknowles - I am merging this based on your approval and the successful tests run.

…r transaction boundaries and transaction ID ordering. * Added integration test for transaction boundaries and transaction ID ordering. Made small fixes in ordered by key integration test. * [BEAM-9150] Fix beam_PostRelease_Python_Candidate (python RC validation scripts) (#16955) * Use default context output rather than outputWithTimestamp for ElasticsearchIO * Palo Alto case study - fix link * [BEAM-12777] Removed current docs version redirect * Merge pull request #16850: [BEAM-11205] Upgrade Libraries BOM dependencies to 24.3.0 * Update GCP Libraries BOM version to 24.3.0 * Update associated dependencies * Merge pull request #16484 from [BEAM-13633] [Playground] Implement method to get a default example for each SDKs * Implement method to get a default example for each SDKs * Add error handling * Added saving of precompiled objects catalog to cache at the server startup * Added caching of the catalog only in case of unspecified SDK * Update regarding comments * Update regarding comments * Simplified logging regarding comment * Get defaultExamplePath from the corresponding config * Refactoring code * Add the `link` field to response * Remove gjson; Resolve conflicts; * Refactoring code * Getting default precompiled object from cache * Refactoring code * Added saving of precompiled objects catalog to cache at the server startup * Added caching of the catalog only in case of unspecified SDK * Update regarding comments * Update regarding comments * Simplified logging regarding comment * Updates regarding comments * Update for environment_service_test.go * Get default example from catalog * GetCatalogFromCacheOrStorage method * Update licenses * Update licenses; Resolve conflicts; * [BEAM-13633][Playground] Change saving default precompiled objects to the cache * [BEAM-13633][Playground] Change logic of saving and receiving info about default precompiled objects * [BEAM-13633][Playground] Separate for each sdk * [BEAM-13633][Playground] regenerate proto files * Add code of the default example to response * Revert "Add code of the default example to response" This reverts commit da6baa0. * Refactoring code * Refactoring code; Add test; * Edit commentaries * Refactoring code * Add bucket name to methods Co-authored-by: Artur Khanin <[email protected]> Co-authored-by: AydarZaynutdinov <[email protected]> Co-authored-by: Pavel Avilov <pavel.avilov> * Add 2022 events blog post (#16975) * Clean up Go formatter suggestions (#16973) * [BEAM-14012] Add go fmt to Github Actions (#16978) * [BEAM-13911] Add basic tests to Go direct runner. (#16979) * [BEAM-13960] Add support for more types when converting from between row and proto (#16875) * Adding schema support. * Addressing feedback. * Bump org.mongodb:mongo-java-driver to 3.12.10 * [BEAM-13973] Link Dataproc Flink master URLs to the InteractiveRunner when FlinkRunner is used (#16904) * [BEAM-13925] Turn pr bot on for go prs (#16984) * [BEAM-13964] Bump kotlin to 1.6.x (#16882) * [BEAM-13964] Bump kotlin to 1.6.x * [BEAM-13964] Bump kotlin to 1.6.x * [BEAM-13964] fix warnings in Kotlin compilation * Skipping flaky sad-path tests for Spanner changestreams * Merge pull request #16906: [BEAM-13974] Handle idle Storage Api streams * Merge pull request #16562 from [BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter) * [BEAM-13051] Pylint no-name-in-module and no-value-for-parameter warnings enabled * [BEAM-13051] Fixed no-value-for-parameter warning for missing default values * [BEAM-13051] Fixed parameters warnings * [BEAM-13925] A couple small pr-bot bug fixes (#16996) * [BEAM-14029] Add getter, setter for target maven repo (#16995) * [BEAM-13903] Improve coverage of metricsx package (#16994) * [BEAM-13892] Improve coverage of avroio package (#16990) * [adhoc] Prepare aws2 ClientConfiguration for json serialization and cleanup AWS Module (#16894) * [adhoc] Prepare aws2 ClientConfiguration and related classes for json serialization and cleanup AWS Module * Merge pull request #16879 from [BEAM-12164] Add javadocs to SpannerConfig * Add tests and config for retry * lint * add tests * lint * Delete tests not passing * Rebase on apache beam master * review changes * review changes * add javadocs to SpannerConfig * revert * add full stops * [Cleanup] Update pre-v2 go package references (#17002) * [BEAM-13885] Add unit tests to window package (#16971) * Merge pull request #16891 from [BEAM-13872] [Playground] Increase test coverage for the code_processing package * Increase test coverage for the code_processing package * Refactoring code * Add test cases with mock cache * Add test for processCompileSuccess method * Update test names * Refactoring code * Merge pull request #16912 from [BEAM-13878] [Playground] Increase test coverage for the fs_tool package * Increase test coverage for the fs_tool package * Rename folder * Remove useless variable * Update test names * Merge pull request #16946 from [BEAM-13873] [Playground] Increase test coverage for the environment package * Increase test coverage for the environment package * Update test names * Refactoring code * Add bucket name to method * [BEAM-13999] playground - support vertical orientation for graph * [BEAM-13951] Update mass_comment.py list of Run commands (#16889) * BEAM-13951: Sort run command list * BEAM-13951: Update list * fixup! BEAM-13951: Update list * [BEAM-10652] Allow Clustering without Partition in BigQuery (#16578) * [BEAM-10652] removed check that blocked clustering without partitioning * [BEAM-10652] allow clustering without requiring partition * newline * added needed null * remove testClusteringThrowsWithoutPartitioning * update clustering * formatting * now compiles * passes spotless * update doc * focus on single test * spotless * run all ITs * spotless * testing with time partitioning * checking * set clustering independant of partitioning * remove timepart from it * spotless * removed test * added TODO * removed block of unneded code/comment * remove override to v3 coder * Spotless cleanup * re-add override to v3 coder * spotless * adding checksum ( wrong value ) * added needed query var * use tableName as var * DATASET NAME * project name in query * update query * change tests * remove unneeded imports * remove rest of forgotten * add rows * 16000 bytes * bigint * streaming test * spotless * methods * end stream * stream method and naming * nostream * streaming * streamingoptions * without streaming example * string column instead of date -- related to BEAM-13753 * mor strings * spotless * revert, only DEFAULT and FILE_LOADS * [BEAM-13857] Add K:V flags for expansion service jars and addresses to Go ITs. (#16908) Adds functionality for running jars to the Go integration test framework, and uses this functionality to implement handling of K:V flags for providing expansion service jars and addresses to the test framework. This means that tests can simply get the address of an expansion service with the appropriate label, and this feature will handle running a jar if necessary, or just using the passed in endpoint otherwise. * BEAM-14011 fix s3 filesystem multipart copy * Merge pull request #16842 from [BEAM-13932][Playground] Container's user privileges * [BEAM-13932][Playground] Change Dockerfiles * [BEAM-13932][Playground] Update proxy and permissions for the container's user * [BEAM-13932][Playground] Update permissions for the container's user for scio * Doc updates and blog post for 2.37.0 (#16887) * Doc updates and blog post for 2.37.0 * Add BEAM-13980 to known issues * Update dates * Drop known issue (fix cherrypicked) * Add license * Add missing # * Remove resolved issue in docs + update class path on sample (#17018) * [BEAM-14016] Fixed flaky postcommit test (#17009) Fixed SpannerWriteIntegrationTest.test_spanner_update by fixing the metric exporter usage in spannerio. * [BEAM-13925] months in date constructor are 0 indexed * [BEAM-13947] Add split() and rsplit(), non-deferred column operations on categorical columns (#16677) * Add split/rsplit; Need to refactor regex * Support Regex; Refactor tests * Remove debugger * fix grammar * Fix passing regex arg * Reorder imports * Address PR comments; Simplify kwargs * Simplify getting columns for split_cat * Update doctests to skip expand=True operations * Fix missing doctest * py: Import beam plugins before starting SdkHarness * BEAM-14026 - Fixes bug related to Unnesting nested rows in an array (#16988) * Suggested changes to handle nested row in an array * Beam-14026 Suggested changes to handle nested row in an array * Beam-14026 Enhanced by segregating the code from getBaseValues enhanced test case and example. * Beam-14026 The code is moved from Row to avoid impact to the public interface. The code is moved to BeamUnnestRel.java since its the caller class. The Example code was duplicate, hence dropped. build.gradle updated with the removal of example code. * Remove resolved issue in notebook * Bump numpy bound to include 1.22 and regenerate container deps. * [BEAM-13925] Add ability to get metrics on pr-bot performance (#16985) * Add script to get metrics on pr-bot performance * Respond to feedback * fix bad condition * [BEAM-11085] Test that windows are correctly observed in DoFns * Give pr bot write permissions on pr update * Adding a logical type for Schemas using proto serialization. (#16940) * BEAM-13765 missing PAssert methods (#16668) * [BEAM-13909] improve coverage of Provision package (#17014) * improve coverage of provision package * updated comments * [BEAM-14050] Update taxi.go example instructions * Merge pull request #17027: [BEAM-11205] Upgrade GCP Libraries BOM dependencies to 24.4.0 * [BEAM-13709] Inconsistent behavior when parsing boolean flags across different APIs in Python SDK (#16929) * Update dataflow API client. * Instructions for updating apitools generated files. * [BEAM-10976] Bundle finalization: Harness and some exec changes (#16980) * Bundle finalization harness side changes * Add testing * Iterate over pardos directly * Track bundlefinalizer in plan.go not pardo * Remove outdated test * Fix pointer issue * Update todos to reference jiras * Cleanup from feedback * Doc nit Co-authored-by: Daniel Oliveira <[email protected]> * GetExpirationTime comment Co-authored-by: github-actions <[email protected]> Co-authored-by: Daniel Oliveira <[email protected]> * Merge pull request #16976 from [BEAM-14010] [Website] Add Playground section to the Home page * [BEAM-14010] [Website] Add Playground section to the Home page * Update button to "Try Playground" Co-authored-by: Aydar Zainutdinov <[email protected]> * [BEAM-14010] [Website] change button name * [BEAM-14010] [Website] align header to center * [BEAM-14010] [Website] change link Co-authored-by: Alex Kosolapov <[email protected]> Co-authored-by: Aydar Zainutdinov <[email protected]> * [BEAM-12447] Upgrade cloud build client and add/cleanup options (#17032) * Merge pull request #17036 from [BEAM-12164] Convert all static instances to be transient in the connector in order to enable concurrent testing * Convert all static instances to be transient in the connector in order to enable concurrent testing * Initialized fields to null * nullness * Suppress uninitialized warnings * Remove resetting dao factory fields in SpannerChangeStreamErrorTest.java * Add validation package * fix variable reference (#16991) * Committed changes * Print more logging * More logging * Made pipelines streaming * Made small fixes * Small fixes * Ran spotless Apply Co-authored-by: emily <[email protected]> Co-authored-by: egalpin <[email protected]> Co-authored-by: Aydar Farrakhov <[email protected]> Co-authored-by: Miguel Hernandez <[email protected]> Co-authored-by: Benjamin Gonzalez <[email protected]> Co-authored-by: Pavel Avilov <[email protected]> Co-authored-by: Artur Khanin <[email protected]> Co-authored-by: AydarZaynutdinov <[email protected]> Co-authored-by: Ahmet Altay <[email protected]> Co-authored-by: Jack McCluskey <[email protected]> Co-authored-by: Robert Burke <[email protected]> Co-authored-by: laraschmidt <[email protected]> Co-authored-by: Alexey Romanenko <[email protected]> Co-authored-by: Victor <[email protected]> Co-authored-by: Danny McCormick <[email protected]> Co-authored-by: Masato Nakamura <[email protected]> Co-authored-by: Pablo Estrada <[email protected]> Co-authored-by: reuvenlax <[email protected]> Co-authored-by: Miguel Hernandez <[email protected]> Co-authored-by: Moritz Mack <[email protected]> Co-authored-by: Zoe <[email protected]> Co-authored-by: Brian Hulette <[email protected]> Co-authored-by: brucearctor <[email protected]> Co-authored-by: Daniel Oliveira <[email protected]> Co-authored-by: sp029619 <[email protected]> Co-authored-by: David Cavazos <[email protected]> Co-authored-by: Ning Kang <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Andy Ye <[email protected]> Co-authored-by: Rahul Iyer <[email protected]> Co-authored-by: abhijeet-lele <[email protected]> Co-authored-by: Valentyn Tymofieiev <[email protected]> Co-authored-by: Marcin Kuthan <[email protected]> Co-authored-by: Ritesh Ghorse <[email protected]> Co-authored-by: Jack McCluskey <[email protected]> Co-authored-by: ansh0l <[email protected]> Co-authored-by: Anand Inguva <[email protected]> Co-authored-by: Robert Bradshaw <[email protected]> Co-authored-by: Daniel Oliveira <[email protected]> Co-authored-by: bullet03 <[email protected]> Co-authored-by: Alex Kosolapov <[email protected]> Co-authored-by: Yichi Zhang <[email protected]> Co-authored-by: Nancy Xu <[email protected]>

BEAM-13765 missing PAssert methods

5ea7b3b

kennknowles reviewed Feb 1, 2022

View reviewed changes

kennknowles approved these changes Feb 11, 2022

View reviewed changes

aaltay closed this Mar 7, 2022

aaltay reopened this Mar 7, 2022

github-actions bot added the java label Mar 7, 2022

Merge branch 'apache:master' into BEAM-13765_passert_missing_methods

631f2bf

aaltay merged commit 9833b7b into apache:master Mar 8, 2022

mkuthan deleted the BEAM-13765_passert_missing_methods branch March 9, 2022 10:12

nancyxu123 pushed a commit to nancyxu123/beam that referenced this pull request Mar 10, 2022

BEAM-13765 missing PAssert methods (apache#16668)

d8cea63

mkuthan mentioned this pull request Jun 5, 2022

Missing IterableAssert.inOnlyPane and SingletonAssert.inWindow methods #21374

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BEAM-13765 missing PAssert methods #16668

BEAM-13765 missing PAssert methods #16668

mkuthan commented Jan 31, 2022 •

edited

Loading

mkuthan commented Jan 31, 2022

mkuthan commented Feb 1, 2022

kennknowles Feb 1, 2022

mkuthan Feb 1, 2022

kennknowles Feb 1, 2022

mkuthan Feb 1, 2022

y1chi commented Feb 11, 2022

kennknowles commented Feb 11, 2022

kennknowles commented Feb 11, 2022

aaltay commented Feb 25, 2022

mkuthan commented Feb 25, 2022

aaltay commented Feb 25, 2022

mkuthan commented Mar 7, 2022

aaltay commented Mar 7, 2022

mkuthan commented Mar 7, 2022

aaltay commented Mar 8, 2022

aaltay commented Mar 8, 2022

BEAM-13765 missing PAssert methods #16668

BEAM-13765 missing PAssert methods #16668

Conversation

mkuthan commented Jan 31, 2022 • edited Loading

ValidatesRunner compliance status (on master branch)

Examples testing status on various runners

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Pre-Commit Tests Status (on master branch)

GitHub Actions Tests Status (on master branch)

mkuthan commented Jan 31, 2022

mkuthan commented Feb 1, 2022

kennknowles Feb 1, 2022

Choose a reason for hiding this comment

mkuthan Feb 1, 2022

Choose a reason for hiding this comment

kennknowles Feb 1, 2022

Choose a reason for hiding this comment

mkuthan Feb 1, 2022

Choose a reason for hiding this comment

y1chi commented Feb 11, 2022

kennknowles commented Feb 11, 2022

kennknowles commented Feb 11, 2022

aaltay commented Feb 25, 2022

mkuthan commented Feb 25, 2022

aaltay commented Feb 25, 2022

mkuthan commented Mar 7, 2022

aaltay commented Mar 7, 2022

mkuthan commented Mar 7, 2022

aaltay commented Mar 8, 2022

aaltay commented Mar 8, 2022

mkuthan commented Jan 31, 2022 •

edited

Loading

`ValidatesRunner` compliance status (on master branch)