-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13685] Enable users to specify cache directory under Interactive Beam options #16555
Conversation
…nd streaming_cache. Also includes corresponding tests.
R: @kevingg |
Codecov Report
@@ Coverage Diff @@
## master #16555 +/- ##
==========================================
+ Coverage 74.61% 83.61% +8.99%
==========================================
Files 653 452 -201
Lines 81804 62091 -19713
==========================================
- Hits 61038 51917 -9121
+ Misses 19785 10174 -9611
+ Partials 981 0 -981
Continue to review full report at Codecov.
|
sdks/python/apache_beam/runners/interactive/interactive_beam.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
Outdated
Show resolved
Hide resolved
… constructors to where FileBasedCacheManager and StreamingCache are created.
sdks/python/apache_beam/runners/interactive/interactive_beam.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/interactive_environment.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/interactive_beam.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/cache_manager_test.py
Outdated
Show resolved
Hide resolved
@victorplusc Please refer https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-Runningyapfformattermanually to format your code so that you can pass the PythonFormatter and PythonLint presubmit, thanks! |
sdks/python/apache_beam/runners/interactive/interactive_beam.py
Outdated
Show resolved
Hide resolved
…cache_root option example usage.
…dCacheManager when a value for interactive_beam.options.cache_root has been set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few nits, LGTM.
sdks/python/apache_beam/runners/interactive/background_caching_job.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/interactive_beam.py
Outdated
Show resolved
Hide resolved
…dded ValueError when GCS path is used in interactive_environment.py. Removed unsupported example docstring. Additionally, fixes incomplete sentence in test comment.
…ified in interactive_beam.options.cache_root
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.