Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13685] Enable users to specify cache directory under Interactive Beam options #16555

Merged
merged 23 commits into from
Jan 21, 2022

Conversation

victorplusc
Copy link
Contributor

@victorplusc victorplusc commented Jan 19, 2022

  • Adds cache_root option under interactive_beam.py and interactive_options.py
  • Integrates new cache_root from interactive_beam.py into interactive_environment.py and background_caching_job.py
  • Includes unit tests under cache_manager_test.py and streaming_cache_test.py
  • Jira ticket: https://issues.apache.org/jira/browse/BEAM-13685

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@victorplusc
Copy link
Contributor Author

R: @kevingg
R: @rohdesamuel

@victorplusc victorplusc marked this pull request as ready for review January 19, 2022 00:34
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #16555 (7782831) into master (3759d44) will increase coverage by 8.99%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16555      +/-   ##
==========================================
+ Coverage   74.61%   83.61%   +8.99%     
==========================================
  Files         653      452     -201     
  Lines       81804    62091   -19713     
==========================================
- Hits        61038    51917    -9121     
+ Misses      19785    10174    -9611     
+ Partials      981        0     -981     
Impacted Files Coverage Δ
...n/apache_beam/runners/interactive/cache_manager.py 90.97% <ø> (ø)
...eam/runners/interactive/caching/streaming_cache.py 96.65% <ø> (+1.25%) ⬆️
...beam/runners/interactive/background_caching_job.py 94.26% <50.00%> (-2.29%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.84% <50.00%> (-0.88%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 77.35% <100.00%> (+1.74%) ⬆️
...runners/interactive/options/interactive_options.py 86.66% <100.00%> (+0.95%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.26% <0.00%> (-0.25%) ⬇️
sdks/python/apache_beam/examples/wordcount.py 93.10% <0.00%> (ø)
...s/python/apache_beam/examples/wordcount_minimal.py 92.85% <0.00%> (ø)
...python/apache_beam/examples/wordcount_debugging.py 95.91% <0.00%> (ø)
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3759d44...7782831. Read the comment docs.

@nika-qubit
Copy link
Contributor

@victorplusc Please refer https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-Runningyapfformattermanually to format your code so that you can pass the PythonFormatter and PythonLint presubmit, thanks!

Copy link
Contributor

@nika-qubit nika-qubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few nits, LGTM.

…dded ValueError when GCS path is used in interactive_environment.py. Removed unsupported example docstring. Additionally, fixes incomplete sentence in test comment.
…ified in interactive_beam.options.cache_root
@nika-qubit nika-qubit merged commit 737be25 into apache:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants