Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11648] Resubmit Storage API sink with broken test removed. #14309

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

reuvenlax
Copy link
Contributor

The test was broken and didn't test anything. A better test would be to modify BigQueryTornadoes to test this path, but we will do this in a different PR (first we need to ensure that the testing project is whitelisted by BigQuery).

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #14309 (60230dd) into master (83bd548) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14309      +/-   ##
==========================================
- Coverage   83.41%   83.39%   -0.03%     
==========================================
  Files         469      469              
  Lines       58727    58727              
==========================================
- Hits        48990    48978      -12     
- Misses       9737     9749      +12     
Impacted Files Coverage Δ
...amples/snippets/transforms/elementwise/__init__.py
..._beam/testing/benchmarks/nexmark/queries/query6.py
...ld/srcs/sdks/python/apache_beam/io/filesystemio.py
...on/apache_beam/runners/portability/spark_runner.py
.../srcs/sdks/python/apache_beam/examples/__init__.py
...hon/apache_beam/examples/complete/game/__init__.py
...e_beam/examples/complete/game/hourly_team_score.py
...cs/sdks/python/apache_beam/portability/__init__.py
...ython/apache_beam/io/aws/clients/s3/fake_client.py
...eam/runners/interactive/display/display_manager.py
... and 928 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83bd548...60230dd. Read the comment docs.

@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

Copy link
Contributor

@boyuanzz boyuanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the test. This PR is ready to merge once all tests pass.

@reuvenlax
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

@reuvenlax
Copy link
Contributor Author

run dataflow streaming validatesrunner

@reuvenlax reuvenlax merged commit 48096fc into apache:master Mar 23, 2021
@@ -490,6 +518,7 @@ public Job getJob(JobReference jobRef, Sleeper sleeper, BackOff backoff)
private DatasetServiceImpl(BigQueryOptions bqOptions) {
this.errorExtractor = new ApiErrorExtractor();
this.client = newBigQueryClient(bqOptions).build();
this.newWriteClient = newBigQueryWriteClient(bqOptions);
Copy link
Member

@TheNeuralBit TheNeuralBit May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're supposed to manage the lifecycle of this client and close it when done. Since this code doesn't do that users see SEVERE errors (e.g. BEAM-12359) whenever they use BigQueryIO. I filed BEAM-12365 for this.

@pabloem
Copy link
Member

pabloem commented Sep 7, 2021

Wasn't the removed broken test an integration test for the feature? How will we test the feature in an ongoing basis for integration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants