[BEAM-475] Enable javadoc for all modules by default #1290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalperi
changed the title
dhalperi
changed the title
dhalperi
commented
Nov 5, 2016
| @@ -73,7 +73,7 @@ | |||
| * results, e.g. for 'team prizes'. We're now outputting window results as they're | |||
| * calculated, giving us much lower latency than with the previous batch examples. | |||
| * | |||
| * <p>Run {@link injector.Injector} to generate pubsub data for this pipeline. The Injector | |||
There was a problem hiding this comment.
file JIRA: the injector is still referred to in some examples.
dhalperi
commented
Nov 5, 2016
| @@ -65,29 +65,6 @@ | |||
|
|
|||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-javadoc-plugin</artifactId> | |||
There was a problem hiding this comment.
replaced by my open PR for javadoc aggregation.
dhalperi
commented
Nov 5, 2016
|
|
||
| <offlineLinks> | ||
| <offlineLink> | ||
| <url>https://developers.google.com/api-client-library/java/google-api-java-client/reference/1.20.0/</url> |
There was a problem hiding this comment.
TODO: figure out where these connections go.
dhalperi
commented
Nov 5, 2016
| * | ||
| * <p>Note that this coder standalone will not produce an Ism file. This coder can be used | ||
| * to materialize a {@link PCollection} of {@link IsmRecord}s. Only when this coder | ||
| * is combined with an {@link IsmSink} will one produce an Ism file. |
There was a problem hiding this comment.
IsmSink is not in the Beam SDK
davorbonaci
approved these changes
Nov 5, 2016
| * PCollection<String> lines = ... ; | ||
| * PCollection<String> words = | ||
| * lines.apply(ParDo.of(new DoFn<String, String>() { | ||
| * @ProcessElement | ||
| * {@verbatim @}ProcessElement |
There was a problem hiding this comment.
literal? (here and elsewhere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix several issues in several modules that were improperly tested before.
R: @davorbonaci