Undo changes to BeamModulePlugin.groovy

[damccorm]

These were added in #28255 but it looks like the assumption that these would function normally was baked deeper than we were aware of.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[damccorm]

Run Java_Pulsar_IO_Direct PreCommit

[codecov]

Codecov Report

Merging #28356 (63890b9) into master (72e6b9a) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28356      +/-   ##
==========================================
- Coverage   72.34%   72.34%   -0.01%     
==========================================
  Files         681      681              
  Lines      100354   100357       +3     
==========================================
  Hits        72603    72603              
- Misses      26171    26174       +3     
  Partials     1580     1580              

Flag	Coverage Δ
python	82.89% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

[damccorm]

@volatilemolotov this actually works and the snapshot publishes correctly - https://github.com/apache/beam/actions/runs/6112953970/job/16591456917 publishes the most recent one on Sept 7. For example https://repository.apache.org/content/repositories/snapshots/org/apache/beam/beam-sdks-java-transform-service-launcher/2.51.0-SNAPSHOT/

I guess the gradle publish job already automatically appends a unique timestamp

[damccorm]

R: @Abacn @volatilemolotov

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[volatilemolotov]

I guess the gradle publish job already automatically appends a unique timestamp
This was not clear to me unfortunately. I guess it was deeper somewhere.

If the versioning is correct now then lets merge this

[Abacn]

LGTM, thanks!

[Abacn]

Run Java PreCommit

[Abacn]

Just notice that this PR does not trigger Java PreCommit GitHub Action. We'll need to add beammoduleplugin to its triggering path

[damccorm]

Run Java_GCP_IO_Direct PreCommit

[damccorm]

Run Java_Spark3_Versions PreCommit

[damccorm]

Run Python_Runners PreCommit

[damccorm]

Run Java PreCommit

[kennknowles]

This is normal "maven dependency" behavior by design. "SNAPSHOT" is a magic keyword that turns into a date stamp when publishing.

[kennknowles]

It works at both ends: when a client depends on a SNAPSHOT version, it will grab the latest datestamped version available.

[volatilemolotov]

Was not aware of that behavior, thanks for clarification