Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][prism]: Insufficient context when prism is unable to LP unknown coders (eg. base coder is missing). #28126

Closed
1 of 15 tasks
lostluck opened this issue Aug 23, 2023 · 0 comments
Closed
1 of 15 tasks

[Bug][prism]: Insufficient context when prism is unable to LP unknown coders (eg. base coder is missing). #28126

lostluck opened this issue Aug 23, 2023 · 0 comments
Assignees
@lostluck
Labels
bug go P3
Milestone
2.51.0 Release

Comments

@lostluck
Copy link
Contributor

What happened?

When attempting to run the Swift SDK wordcount, prism failed due to a missing base coder, but ultimately there was no coder id. However, each transform and PCollection had appropriate coders.

Aside from resolving the root cause triggering the issue, prism should provide appropriate context for that error instead of lazily panicking. This requires plumbing errors all the way back up, allowing clarity in the error message for what prism was doing at the time.

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@lostluck lostluck self-assigned this Aug 23, 2023
lostluck added a commit to lostluck/beam that referenced this issue Aug 25, 2023
@lostluck
[apache#28126] plumb coder errors with better context.
147434c
@lostluck lostluck mentioned this issue Aug 25, 2023
Merged
3 tasks
lostluck added a commit that referenced this issue Aug 25, 2023
@lostluck
[#28126] plumb coder errors with better context. (#28164)
db23583 
* [#28126] plumb coder errors with better context.

* Add hard clear checks for SDK error: no windows being encoded.

* parse log

* fix log line parsing

* fmt

---------

Co-authored-by: lostluck <[email protected]>
@lostluck lostluck mentioned this issue Aug 25, 2023
Merged
3 tasks
lostluck added a commit to lostluck/beam that referenced this issue Aug 30, 2023
@lostluck
[apache#28126] plumb coder errors with better context. (apache#28164)
26d2dfc 
* [apache#28126] plumb coder errors with better context.

* Add hard clear checks for SDK error: no windows being encoded.

* parse log

* fix log line parsing

* fmt

---------

Co-authored-by: lostluck <[email protected]>
@github-actions github-actions bot added this to the 2.51.0 Release milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostluck lostluck

Labels
bug go P3
Projects
None yet
Milestone
2.51.0 Release
Development

No branches or pull requests
1 participant
@lostluck