Skip to content

Commit

Permalink
Adding comment to reason why 32G is recomemnded value
Browse files Browse the repository at this point in the history
  • Loading branch information
arvindram03 committed Sep 18, 2023
1 parent 8127753 commit f254d97
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions sdks/java/container/boot.go
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,10 @@ func makePipelineOptionsFile(options string) error {
// it returns 70% of the physical memory on the machine. If it cannot determine
// that value, it returns 1GB. This is an imperfect heuristic. It aims to
// ensure there is memory for non-heap use and other overhead, while also not
// underutilizing the machine. if set_recommended_max_xmx experiment is enabled, sets xmx
// to 32G
// underutilizing the machine. if set_recommended_max_xmx experiment is enabled,
// sets xmx to 32G. Under 32G JVM enables CompressedOops. CompressedOops
// utilizes memory more efficiently, and has positive impact on GC performance
// and cache hit rate.
func heapSizeLimit(info *fnpb.ProvisionInfo, setRecommendedMaxXmx bool) uint64 {
if setRecommendedMaxXmx {
return 32 << 30
Expand Down

0 comments on commit f254d97

Please sign in to comment.