Skip to content

Commit

Permalink
Disable a permared suite. (#32493)
Browse files Browse the repository at this point in the history
* Disable a permared suite.

* Disable by removing trigger-on-filechange

* Remove the suite from the release validation scripts.

* Try to add sickbay into name.

* Don't require release suite triggers on test suites with the word 'disabled'.
  • Loading branch information
tvalentyn authored Sep 18, 2024
1 parent 06e2170 commit aeead3f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ task check {
paths = workflow.getAt(true).pull_request_target.paths as List
} catch (Exception e) {
errors.add("Fail to get the trigger path for ${fname}. " +
"Make sure it has a pull_request_target trigger.")
"Make sure it has a pull_request_target trigger.")
return
}

// precommit and postcommit should triggered by this specific file
// this is to ensure not missing test during release branch verification
if (paths != null && !paths.contains('release/trigger_all_tests.json') && !fname.toLowerCase().contains('sickbay')) {
if (paths != null && !paths.contains('release/trigger_all_tests.json') && !fname.toLowerCase().contains('sickbay') && !workflow.name.toLowerCase().contains('disabled')) {
errors.add("Error validating ${fname}: " +
"Please add 'release/trigger_all_tests.json' to the trigger path")
return
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,16 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: PostCommit XVR GoUsingJava Dataflow
# TODO(https://github.com/apache/beam/issues/32492): re-enable the suite
# on cron and add release/trigger_all_tests.json to trigger path once fixed.

name: PostCommit XVR GoUsingJava Dataflow (DISABLED)

on:
schedule:
- cron: '45 5/6 * * *'
# schedule:
# - cron: '45 5/6 * * *'
pull_request_target:
paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_XVR_GoUsingJava_Dataflow.json']
paths: ['.github/trigger_files/beam_PostCommit_XVR_GoUsingJava_Dataflow.json']
workflow_dispatch:

#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
Expand Down

0 comments on commit aeead3f

Please sign in to comment.