Skip to content

Commit

Permalink
Doc + debug further
Browse files Browse the repository at this point in the history
  • Loading branch information
damccorm committed Dec 23, 2024
1 parent 4c8992c commit adc70ad
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
## Breaking Changes

* Upgraded ZetaSQL to 2024.11.1 ([#32902](https://github.com/apache/beam/pull/32902)). Java11+ is now needed if Beam's ZetaSQL component is used.
* AWS V1 I/Os have been removed (Java). As part of this, x-lang Python I/Os no longer support setting producer_properties ([#33430](https://github.com/apache/beam/issues/33430)).
* X behavior was changed ([#X](https://github.com/apache/beam/issues/X)).

## Deprecations
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ public <BuilderT extends AwsClientBuilder<BuilderT, ClientT>, ClientT> BuilderT

if (skipCertificateVerification) {
client.tlsKeyManagersProvider(NoneTlsKeyManagersProvider.getInstance());
throw new Exception("Made it this far - probably means the tlsKeyManagersProvider is not right");
}

// must use builder to make sure client is managed by the SDK
Expand Down Expand Up @@ -212,6 +213,7 @@ public <BuilderT extends AwsClientBuilder<BuilderT, ClientT>, ClientT> BuilderT

if (skipCertificateVerification) {
client.tlsKeyManagersProvider(NoneTlsKeyManagersProvider.getInstance());
throw new Exception("Made it this far - probably means the tlsKeyManagersProvider is not right");
}

// must use builder to make sure client is managed by the SDK
Expand Down
6 changes: 3 additions & 3 deletions sdks/python/apache_beam/io/kinesis.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ def __init__(
:param verify_certificate: Enable or disable certificate verification.
Never set to False on production. True by default.
:param partition_key: Specify default partition key.
:param producer_properties: Specify the configuration properties for Kinesis
Producer Library (KPL) as dictionary.
Example: {'CollectionMaxCount': '1000', 'ConnectTimeout': '10000'}
:param producer_properties: (Deprecated) This option no longer is available
since the AWS IOs upgraded to v2. Trying to set it will lead to an
error. For more info, see https://github.com/apache/beam/issues/33430.
:param expansion_service: The address (host:port) of the ExpansionService.
"""
if producer_properties is not None:
Expand Down

0 comments on commit adc70ad

Please sign in to comment.