Skip to content

Commit

Permalink
Allow longer Class-Path entries (#23269)
Browse files Browse the repository at this point in the history
jar Class-Path entries have a max line length which, when
exceeded, will cause java to fail to start. Use newline plus
extra space to support large numbers of jar files.
  • Loading branch information
shanemhansen authored Sep 21, 2022
1 parent c51e1c2 commit 3fe0867
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/utils/subprocess_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def make_classpath_jar(cls, main_jar, extra_jars, cache_dir=None):
manifest.write(b'Manifest-Version: 1.0\n')
manifest.write(main_class)
manifest.write(
b'Class-Path: ' + ' '.join(classpath).encode('ascii') + b'\n')
b'Class-Path: ' + '\n '.join(classpath).encode('ascii') + b'\n')
os.rename(composite_jar + '.tmp', composite_jar)
return composite_jar

Expand Down

0 comments on commit 3fe0867

Please sign in to comment.